You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Matthias J. Sax" <mj...@apache.org> on 2024/07/11 16:24:10 UTC
[VOTE] KIP-1070: Deprecate MockProcessorContext
Hi,
I want to propose a very small KIP. Skipping the DISCUSS step, and
calling for a VOTE directly.
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
-Matthias
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by "Matthias J. Sax" <mj...@apache.org>.
Hi,
Also a +1 (binging) from me.
I am closing this vote with the KIP being accepted with 4 binding +1s
from Sophie, Bill, Lucas, and myself.
Thanks a lot!
-Matthias
On 7/26/24 10:52 AM, Matthias J. Sax wrote:
> I updated the KIP accordingly.
>
> If there is no further follow usp, I'll close the vote shortly.
>
>
> -Matthias
>
> On 7/21/24 10:24 PM, Matthias J. Sax wrote:
>> I just realized that both
>>
>> - ValueTransformerWithKey and
>> - ValueTransfromerWithKeySupplier
>>
>> are still used by non-deprecated `KTable#transformValues()`. So we
>> cannot deprecate them with this KIP.
>>
>> I filed https://issues.apache.org/jira/browse/KAFKA-17178 for tracking.
>>
>> As an alternative, we could extend this KIP and include K17178 that I
>> just filed, but it would be a larger change. I frankly just wanted to
>> tie up a few loose ends w/o the need to do a larger KIP.
>>
>> Hope you are all ok with keeping the KIP as-is and simple, and we wait
>> for somebody else to pickup K17178.
>>
>> Thoughts?
>>
>>
>> -Matthias
>>
>> On 7/15/24 8:43 PM, Sophie Blee-Goldman wrote:
>>> Makes sense to me -- seems like an oversight since we did correctly
>>> deprecate the old Processor, ProcessorSupplier, etc (not to mention the
>>> #transform, #transformValues methods). Still a +1 (binding) from me
>>>
>>> On Fri, Jul 12, 2024 at 4:41 PM Matthias J. Sax <mj...@apache.org>
>>> wrote:
>>>
>>>> I just realized, that there is more interfaces with a similar
>>>> situation:
>>>>
>>>> - Transformer
>>>> - TransformerSupplier
>>>> - ValueTransformer
>>>> - ValueTransfomerSupplier
>>>> - ValueTransformerWithKey
>>>> - ValueTransfromerWithKeySupplier
>>>>
>>>> Given that `KStream#transform` and `KStream#transformValues` are
>>>> deprecated, it seems we should deprecate all of them, too?
>>>>
>>>>
>>>>
>>>> -Matthias
>>>>
>>>>
>>>> On 7/12/24 1:06 AM, Lucas Brutschy wrote:
>>>>> Sounds good to me!
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com>
>>>>> wrote:
>>>>>>
>>>>>> +1 (binding)
>>>>>>
>>>>>> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <
>>>> sophie@responsive.dev>
>>>>>> wrote:
>>>>>>
>>>>>>> Makes sense to me, +1 (binding)
>>>>>>>
>>>>>>> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org>
>>>> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I want to propose a very small KIP. Skipping the DISCUSS step, and
>>>>>>>> calling for a VOTE directly.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
>>>>>>>>
>>>>>>>>
>>>>>>>> -Matthias
>>>>>>>>
>>>>>>>
>>>>
>>>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by "Matthias J. Sax" <mj...@apache.org>.
I updated the KIP accordingly.
If there is no further follow usp, I'll close the vote shortly.
-Matthias
On 7/21/24 10:24 PM, Matthias J. Sax wrote:
> I just realized that both
>
> - ValueTransformerWithKey and
> - ValueTransfromerWithKeySupplier
>
> are still used by non-deprecated `KTable#transformValues()`. So we
> cannot deprecate them with this KIP.
>
> I filed https://issues.apache.org/jira/browse/KAFKA-17178 for tracking.
>
> As an alternative, we could extend this KIP and include K17178 that I
> just filed, but it would be a larger change. I frankly just wanted to
> tie up a few loose ends w/o the need to do a larger KIP.
>
> Hope you are all ok with keeping the KIP as-is and simple, and we wait
> for somebody else to pickup K17178.
>
> Thoughts?
>
>
> -Matthias
>
> On 7/15/24 8:43 PM, Sophie Blee-Goldman wrote:
>> Makes sense to me -- seems like an oversight since we did correctly
>> deprecate the old Processor, ProcessorSupplier, etc (not to mention the
>> #transform, #transformValues methods). Still a +1 (binding) from me
>>
>> On Fri, Jul 12, 2024 at 4:41 PM Matthias J. Sax <mj...@apache.org> wrote:
>>
>>> I just realized, that there is more interfaces with a similar situation:
>>>
>>> - Transformer
>>> - TransformerSupplier
>>> - ValueTransformer
>>> - ValueTransfomerSupplier
>>> - ValueTransformerWithKey
>>> - ValueTransfromerWithKeySupplier
>>>
>>> Given that `KStream#transform` and `KStream#transformValues` are
>>> deprecated, it seems we should deprecate all of them, too?
>>>
>>>
>>>
>>> -Matthias
>>>
>>>
>>> On 7/12/24 1:06 AM, Lucas Brutschy wrote:
>>>> Sounds good to me!
>>>>
>>>> +1 (binding)
>>>>
>>>> On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com> wrote:
>>>>>
>>>>> +1 (binding)
>>>>>
>>>>> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <
>>> sophie@responsive.dev>
>>>>> wrote:
>>>>>
>>>>>> Makes sense to me, +1 (binding)
>>>>>>
>>>>>> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org>
>>> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I want to propose a very small KIP. Skipping the DISCUSS step, and
>>>>>>> calling for a VOTE directly.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
>>>>>>>
>>>>>>>
>>>>>>> -Matthias
>>>>>>>
>>>>>>
>>>
>>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by "Matthias J. Sax" <mj...@apache.org>.
I just realized that both
- ValueTransformerWithKey and
- ValueTransfromerWithKeySupplier
are still used by non-deprecated `KTable#transformValues()`. So we
cannot deprecate them with this KIP.
I filed https://issues.apache.org/jira/browse/KAFKA-17178 for tracking.
As an alternative, we could extend this KIP and include K17178 that I
just filed, but it would be a larger change. I frankly just wanted to
tie up a few loose ends w/o the need to do a larger KIP.
Hope you are all ok with keeping the KIP as-is and simple, and we wait
for somebody else to pickup K17178.
Thoughts?
-Matthias
On 7/15/24 8:43 PM, Sophie Blee-Goldman wrote:
> Makes sense to me -- seems like an oversight since we did correctly
> deprecate the old Processor, ProcessorSupplier, etc (not to mention the
> #transform, #transformValues methods). Still a +1 (binding) from me
>
> On Fri, Jul 12, 2024 at 4:41 PM Matthias J. Sax <mj...@apache.org> wrote:
>
>> I just realized, that there is more interfaces with a similar situation:
>>
>> - Transformer
>> - TransformerSupplier
>> - ValueTransformer
>> - ValueTransfomerSupplier
>> - ValueTransformerWithKey
>> - ValueTransfromerWithKeySupplier
>>
>> Given that `KStream#transform` and `KStream#transformValues` are
>> deprecated, it seems we should deprecate all of them, too?
>>
>>
>>
>> -Matthias
>>
>>
>> On 7/12/24 1:06 AM, Lucas Brutschy wrote:
>>> Sounds good to me!
>>>
>>> +1 (binding)
>>>
>>> On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com> wrote:
>>>>
>>>> +1 (binding)
>>>>
>>>> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <
>> sophie@responsive.dev>
>>>> wrote:
>>>>
>>>>> Makes sense to me, +1 (binding)
>>>>>
>>>>> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org>
>> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I want to propose a very small KIP. Skipping the DISCUSS step, and
>>>>>> calling for a VOTE directly.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
>>>>>>
>>>>>>
>>>>>> -Matthias
>>>>>>
>>>>>
>>
>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by Sophie Blee-Goldman <so...@responsive.dev>.
Makes sense to me -- seems like an oversight since we did correctly
deprecate the old Processor, ProcessorSupplier, etc (not to mention the
#transform, #transformValues methods). Still a +1 (binding) from me
On Fri, Jul 12, 2024 at 4:41 PM Matthias J. Sax <mj...@apache.org> wrote:
> I just realized, that there is more interfaces with a similar situation:
>
> - Transformer
> - TransformerSupplier
> - ValueTransformer
> - ValueTransfomerSupplier
> - ValueTransformerWithKey
> - ValueTransfromerWithKeySupplier
>
> Given that `KStream#transform` and `KStream#transformValues` are
> deprecated, it seems we should deprecate all of them, too?
>
>
>
> -Matthias
>
>
> On 7/12/24 1:06 AM, Lucas Brutschy wrote:
> > Sounds good to me!
> >
> > +1 (binding)
> >
> > On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com> wrote:
> >>
> >> +1 (binding)
> >>
> >> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <
> sophie@responsive.dev>
> >> wrote:
> >>
> >>> Makes sense to me, +1 (binding)
> >>>
> >>> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org>
> wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> I want to propose a very small KIP. Skipping the DISCUSS step, and
> >>>> calling for a VOTE directly.
> >>>>
> >>>>
> >>>>
> >>>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
> >>>>
> >>>>
> >>>> -Matthias
> >>>>
> >>>
>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by "Matthias J. Sax" <mj...@apache.org>.
I just realized, that there is more interfaces with a similar situation:
- Transformer
- TransformerSupplier
- ValueTransformer
- ValueTransfomerSupplier
- ValueTransformerWithKey
- ValueTransfromerWithKeySupplier
Given that `KStream#transform` and `KStream#transformValues` are
deprecated, it seems we should deprecate all of them, too?
-Matthias
On 7/12/24 1:06 AM, Lucas Brutschy wrote:
> Sounds good to me!
>
> +1 (binding)
>
> On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com> wrote:
>>
>> +1 (binding)
>>
>> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <so...@responsive.dev>
>> wrote:
>>
>>> Makes sense to me, +1 (binding)
>>>
>>> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> I want to propose a very small KIP. Skipping the DISCUSS step, and
>>>> calling for a VOTE directly.
>>>>
>>>>
>>>>
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
>>>>
>>>>
>>>> -Matthias
>>>>
>>>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by Lucas Brutschy <lb...@confluent.io.INVALID>.
Sounds good to me!
+1 (binding)
On Fri, Jul 12, 2024 at 12:55 AM Bill Bejeck <bb...@gmail.com> wrote:
>
> +1 (binding)
>
> On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <so...@responsive.dev>
> wrote:
>
> > Makes sense to me, +1 (binding)
> >
> > On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org> wrote:
> >
> > > Hi,
> > >
> > > I want to propose a very small KIP. Skipping the DISCUSS step, and
> > > calling for a VOTE directly.
> > >
> > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
> > >
> > >
> > > -Matthias
> > >
> >
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by Bill Bejeck <bb...@gmail.com>.
+1 (binding)
On Thu, Jul 11, 2024 at 5:07 PM Sophie Blee-Goldman <so...@responsive.dev>
wrote:
> Makes sense to me, +1 (binding)
>
> On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org> wrote:
>
> > Hi,
> >
> > I want to propose a very small KIP. Skipping the DISCUSS step, and
> > calling for a VOTE directly.
> >
> >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
> >
> >
> > -Matthias
> >
>
Re: [VOTE] KIP-1070: Deprecate MockProcessorContext
Posted by Sophie Blee-Goldman <so...@responsive.dev>.
Makes sense to me, +1 (binding)
On Thu, Jul 11, 2024 at 9:24 AM Matthias J. Sax <mj...@apache.org> wrote:
> Hi,
>
> I want to propose a very small KIP. Skipping the DISCUSS step, and
> calling for a VOTE directly.
>
>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1070%3A+deprecate+MockProcessorContext
>
>
> -Matthias
>