You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/02/06 17:02:29 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #34039: GH-33935: [Go][FlightRPC] Implement Flight SQL extensions

lidavidm commented on code in PR #34039:
URL: https://github.com/apache/arrow/pull/34039#discussion_r1097663685


##########
go/arrow/internal/flight_integration/scenario.go:
##########
@@ -526,17 +526,17 @@ func (m *middlewareScenarioTester) GetFlightInfo(ctx context.Context, desc *flig
 	}, nil
 }
 
-var (
-	// Schema to be returned for mocking the statement/prepared statement
-	// results. Must be the same across all languages
-	QuerySchema = arrow.NewSchema([]arrow.Field{{
-		Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
-		Metadata: flightsql.NewColumnMetadataBuilder().
-			TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
-			TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
-			CatalogName("catalog_test").Precision(100).Metadata(),
-	}}, nil)
-)
+// var (
+// 	// Schema to be returned for mocking the statement/prepared statement
+// 	// results. Must be the same across all languages
+// 	QuerySchema = arrow.NewSchema([]arrow.Field{{
+// 		Name: "id", Type: arrow.PrimitiveTypes.Int64, Nullable: true,
+// 		Metadata: flightsql.NewColumnMetadataBuilder().
+// 			TableName("test").IsAutoIncrement(true).IsCaseSensitive(false).
+// 			TypeName("type_test").SchemaName("schema_test").IsSearchable(true).
+// 			CatalogName("catalog_test").Precision(100).Metadata(),
+// 	}}, nil)
+// )

Review Comment:
   Did you mean to comment this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org