You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by Christian Grobmeier <gr...@gmail.com> on 2009/03/17 08:48:12 UTC

[compress] Patch for SANDBOX-284

Hi all,

just made a quick fix for SANDBOX-284:
https://issues.apache.org/jira/browse/SANDBOX-284

I could not test it with a general working testcase, since this is a
platform problem and i have only OSX.
However, GUMP will not run on windows too, i guess. I think here is
some refactoring necessary to make
this code more testable.

Before I do this, this brings me to a question of codestyle. I prefer
to do quite less in the constructor. TarArchiveEntry does quite much,
and i think this is necessary in this case. The other option would be
to construct it empty and do all that stuff in a setter, which would
bring no benefit. To make it testable, I would have to extract some
methods from the constructor. Normally I would mark them private, but
private methods cannot be tested, except with reflection.

My question is, is it common use at commons to test with reflection in
that special and rare cases? Or should I mark the package scoped, just
for the sake of testability?

I think I would prefer option one, even when it reminds me on the
story with cannonballs and that birds.

Cheers,
Christian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [math] suggesting rational function and trigonometric functions classes

Posted by Bernhard Grünewaldt <be...@gruenewaldt.net>.

Hi Ted,

As you suggested I opened a ticket for this issue:

https://issues.apache.org/jira/browse/MATH-250

:)

- Bernhard

Ted Dunning schrieb:
> Reasoning purely by symmetry, doesn't it seem that where you are headed here
> is toward an extended rational polynomial class that handles rational
> polynomials of a base variable and simple functions of a base variable (such
> as trig functions, log and exp)?
> 
> If so, then having some kind of unified class would probably be a good
> thing.  You could pretty easily support the same functions as the current
> Polynomial class (derivative, multiply, add, negate and so on).  The
> question of log(-1) and sqrt(-1) is likely to come up, but if you add a
> convention for complaining about these, then you should be good to go.
> 
> The next step is to file a JIRA where discussions like this can have a home.
> 
> On Tue, Mar 17, 2009 at 9:01 AM, Bernhard Grünewaldt <
> bernhard@gruenewaldt.net> wrote:
> 
>> Hi,
>>
>> I used already the classes of the analysis package:
>> http://commons.apache.org/math/userguide/analysis.html
>>
>> There is already a fine class for Polynomial Functions which can calculate
>> the derivation:
>>
>> PolynomialFunction.derivative()
>>
>>
>> I would like to suggest a class called "RationalFunction" which can do
>> almost the same but for (you guessed it) Rational Functions.
>>
>> Suggested methods are: derivative() , add(RationalFunction r), a.s.o.
>>
>> http://en.wikipedia.org/wiki/Rational_function
>>
>> If this is something which you would like to have I will start coding it
>> to provide a patch.
>>
>> The next thing is "Trigonometric Functions" and their derivatives:
>>
>>
>> http://en.wikipedia.org/wiki/Trigonometric_function_derivations#Derivatives_of_trigonometric_functions
>>
>> It would also be nice to have classes for that type of function.
>>
>>
>> - Bernhard
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org

Re: [math] suggesting rational function and trigonometric functions classes

Posted by Ted Dunning <te...@gmail.com>.

Reasoning purely by symmetry, doesn't it seem that where you are headed here
is toward an extended rational polynomial class that handles rational
polynomials of a base variable and simple functions of a base variable (such
as trig functions, log and exp)?

If so, then having some kind of unified class would probably be a good
thing.  You could pretty easily support the same functions as the current
Polynomial class (derivative, multiply, add, negate and so on).  The
question of log(-1) and sqrt(-1) is likely to come up, but if you add a
convention for complaining about these, then you should be good to go.

The next step is to file a JIRA where discussions like this can have a home.

On Tue, Mar 17, 2009 at 9:01 AM, Bernhard Grünewaldt <
bernhard@gruenewaldt.net> wrote:

> Hi,
>
> I used already the classes of the analysis package:
> http://commons.apache.org/math/userguide/analysis.html
>
> There is already a fine class for Polynomial Functions which can calculate
> the derivation:
>
> PolynomialFunction.derivative()
>
>
> I would like to suggest a class called "RationalFunction" which can do
> almost the same but for (you guessed it) Rational Functions.
>
> Suggested methods are: derivative() , add(RationalFunction r), a.s.o.
>
> http://en.wikipedia.org/wiki/Rational_function
>
> If this is something which you would like to have I will start coding it
> to provide a patch.
>
> The next thing is "Trigonometric Functions" and their derivatives:
>
>
> http://en.wikipedia.org/wiki/Trigonometric_function_derivations#Derivatives_of_trigonometric_functions
>
> It would also be nice to have classes for that type of function.
>
>
> - Bernhard
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

-- 
Ted Dunning, CTO
DeepDyve