[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #315: [WIP] Incremental processing prototype

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #315: [WIP] Incremental processing prototype
URL: https://github.com/apache/incubator-iceberg/pull/315#discussion_r347104042
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/Table.java
 ##########
 @@ -44,6 +44,15 @@
    */
   TableScan newScan();
 
+
+  /**
+   * @param fromSnapshotId - the last snapshot id read by the user, exclusive
+   * @param toSnapshotId - read incremental data upto this snapshot id
+   * @return a table scan which can read incremental data from {@param fromSnapshotId}
+   * exclusive and up to {@toSnapshotId} inclusive
+   */
+  TableScan newIncrementalScan(long fromSnapshotId, long toSnapshotId);
 
 Review comment:
   I think it is essential that we can start a stream data from a large table and have multiple batches for this. @rdblue, can you elaborate on the batch process you mentioned?
   
   I've also summarized my thoughts on requirements for Structured Streaming sources in [this](https://github.com/apache/incubator-iceberg/issues/179#issuecomment-554666093) comment. Let me know if that makes sense to you, @rdsr @rdblue. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org