You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2023/06/07 14:56:25 UTC

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20021


Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................

IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Experimental builds on systems based on Red Hat Linux v8.x revealed that
snappy-devel is installed only for RedHat-based systems in
bin/bootstrap_system.sh (the script that preps a workstation for local
Impala development). The same library was not installed for Ubuntu
variants -- probably because Impala has been using Snappy from the
toolchain for a long time now.

Subsequent tests revealed that the build and dataload phases can
complete successfully on Red Hat Linux v8.6 even in the absence of this
package, so this patch removes the installation of snappy-devel during
system preparation.

Tested by running bin/bootstrap_system.sh on a newly minted private VM
instance running RedHat Linux 8.6, then running
buildall.sh -skiptests -format -testdata
successfully.

Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
---
M bin/bootstrap_system.sh
1 file changed, 0 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/20021/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 13:07:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Jun 2023 19:46:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9393/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Jun 2023 14:30:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 1: Code-Review+2

Found snappy-devel was added in this patch. Redhat 8 is not released yet at that time.
https://gerrit.cloudera.org/c/11731/8/bin/bootstrap_system.sh

Good to know that we don't need it actually. Thank Laszlo!
Carrying Michael's +1.


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 22:21:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 17:11:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9387/


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 18:30:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9384/


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 15:41:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................

IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Experimental builds on systems based on Red Hat Linux v8.x revealed that
snappy-devel is installed only for RedHat-based systems in
bin/bootstrap_system.sh (the script that preps a workstation for local
Impala development). The same library was not installed for Ubuntu
variants -- probably because Impala has been using Snappy from the
toolchain for a long time now.

Subsequent tests revealed that the build and dataload phases can
complete successfully on Red Hat Linux v8.6 even in the absence of this
package, so this patch removes the installation of snappy-devel during
system preparation.

Tested by running bin/bootstrap_system.sh on a newly minted private VM
instance running RedHat Linux 8.6, then running
buildall.sh -skiptests -format -testdata
successfully.

Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Reviewed-on: http://gerrit.cloudera.org:8080/20021
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 5
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9387/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 09 Jun 2023 13:07:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9384/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 10:16:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Thu, 08 Jun 2023 10:16:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/13222/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 15:19:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12185: Don't install snappy-devel for Red Hat derivatives

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20021 )

Change subject: IMPALA-12185: Don't install snappy-devel for Red Hat derivatives
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20021
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b14e09fa78d51a387a066eb04495f758430fa9d
Gerrit-Change-Number: 20021
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 10 Jun 2023 14:30:40 +0000
Gerrit-HasComments: No