[jira] [Commented] (MAPREDUCE-5830) HostUtil.getTaskLogUrl is not backwards binary compatible with 2.3

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037952#comment-14037952 ] 

Hadoop QA commented on MAPREDUCE-5830:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12651497/MAPREDUCE-5830.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4675//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4675//console

This message is automatically generated.

> HostUtil.getTaskLogUrl is not backwards binary compatible with 2.3
> ------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5830
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5830
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: Akira AJISAKA
>            Priority: Blocker
>         Attachments: MAPREDUCE-5830.patch
>
>
> HostUtil.getTaskLogUrl used to have a signature like this in Hadoop 2.3.0 and earlier:
> public static String getTaskLogUrl(String taskTrackerHostName, String httpPort, String taskAttemptID)
> but now has a signature like this:
> public static String getTaskLogUrl(String scheme, String taskTrackerHostName, String httpPort, String taskAttemptID)
> This breaks source and binary backwards-compatibility.  MapReduce and Hive both have references to this, so their jars compiled against 2.3 or earlier do not work on 2.4.



--
This message was sent by Atlassian JIRA
(v6.2#6252)