You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2017/01/04 14:58:28 UTC
Re: Review Request 53299: Fixed memory leak in implementation of
Future::after().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53299/
-----------------------------------------------------------
(Updated Jan. 4, 2017, 3:58 p.m.)
Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere.
Bugs: MESOS-6484
https://issues.apache.org/jira/browse/MESOS-6484
Repository: mesos
Description
-------
Removes a reference counted pointer that futures kept to themselves
when using the method `Future<T>::after()`.
Diffs (updated)
-----
3rdparty/libprocess/include/process/future.hpp 26bf5851f6562cd73aa4938b3308639144657044
3rdparty/libprocess/src/tests/future_tests.cpp 7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing (updated)
-------
```bash
make check
# Left to run for at least 3_000_000 iterations.
./3rdparty/libprocess/libprocess-tests --gtest_filter="FutureTest.After3" --gtest_repeat=-1 --gtest_break_on_failure
```
Thanks,
Alexander Rojas
Re: Review Request 53299: Fixed memory leak in implementation of
Future::after().
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53299/#review160603
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Jan. 4, 2017, 2:58 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53299/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 2:58 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere.
>
>
> Bugs: MESOS-6484
> https://issues.apache.org/jira/browse/MESOS-6484
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Removes a reference counted pointer that futures kept to themselves
> when using the method `Future<T>::after()`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/future.hpp 26bf5851f6562cd73aa4938b3308639144657044
> 3rdparty/libprocess/src/tests/future_tests.cpp 7c411c7be1849119fe0b070622dbe4488fa11b7a
>
> Diff: https://reviews.apache.org/r/53299/diff/
>
>
> Testing
> -------
>
> ```bash
> make check
> # Left to run for at least 3_000_000 iterations.
> ./3rdparty/libprocess/libprocess-tests --gtest_filter="FutureTest.After3" --gtest_repeat=-1 --gtest_break_on_failure
> ```
>
>
> Thanks,
>
> Alexander Rojas
>
>