You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/09/26 23:45:19 UTC
[PR] refactor(frontend): remove the legacy user-file types [texera]
aglinxinyuan opened a new pull request, #8693:
URL: https://github.com/apache/texera/pull/8693
### What changes were proposed in this PR?
Removes the frontend type layer for "user files", a dashboard entry kind the backend has not served since #2781. **+127/−337 lines.** There is no behaviour change for workflow, dataset or model entries.
- **Types:** `DashboardFile`, `UserFile` and the duplicate `SortMethod` enum in `dashboard-file.interface.ts`. `FileUploadItem` stays, since the uploaders use it.
- **Dashboard entry:** `isDashboardFile`, the file branch and `file` getter of `DashboardEntry`, and `SearchResultItem.file` with its two readers (search-bar `convertToName`, search-service result filter).
- **Registry:** `FileResourceDescriptor` and its wiring in `ResourceRegistryService`, plus `EntityType.File`.
- **Search types:** `"file"` in the search resource-type unions and their JSDoc. `DashboardResource` throws `Unknown resource type: file` for it.
### History
| | |
| --- | --- |
| **Introduced by** | #756 (2020-05-26), "User System File Uploading" (`UserFile`). Wired into the dashboard by #1251 (2021-08-05, `DashboardFile`) and #1966 / #1982 (June 2023, unified search + `DashboardEntry` file branch) |
| **Usage removed by** | #2781 (2024-08-20), "Remove File-Related Components". It deleted `UserFileResource`, `UserFileAccessResource`, the file search query builder and the user-file components |
It has been dead for about two years: no file entry can reach the frontend. #8068 (2026-08-28) later registered `FileResourceDescriptor` for a kind that could no longer appear.
> Reviewer note: most of the spec churn is not coverage loss. The File descriptor was the only registered kind without rename, description, share, download or publish support, so several specs used a File entry to reach those guard branches. They now reach the same branches with a stand-in descriptor instead:
> - `stubBareDescriptor()` in the card-item and list-item specs;
> - an injected `ModelResourceDescriptor` override in the registry spec;
> - `UNPUBLISHABLE_DESCRIPTOR` in the share-access spec.
>
> Only the cases that asserted File-specific behaviour were deleted.
### Any related issues, documentation, discussions?
Closes #8692
### How was this PR tested?
No new tests. The guard-branch specs are kept and re-pointed at a stand-in descriptor, as described above.
From `frontend/`:
- `npx ng test --watch=false --include='src/app/dashboard/**/*.spec.ts' --include='src/app/hub/**/*.spec.ts'`: 72 spec files, all pass.
- `yarn format:ci`: clean.
- `npx ng build`: success.
To re-check:
```
git grep -nwE "DashboardFile|UserFile|isDashboardFile|FileResourceDescriptor" -- frontend # no hits
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove the legacy user-file types [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8693:
URL: https://github.com/apache/texera/pull/8693#issuecomment-5851008759
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@tanishqgandhi1908`, `@yangzhang75`, `@carloea2`
You can notify them by mentioning `@tanishqgandhi1908`, `@yangzhang75`, `@carloea2` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove the legacy user-file types [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #8693:
URL: https://github.com/apache/texera/pull/8693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(frontend): remove the legacy user-file types [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8693:
URL: https://github.com/apache/texera/pull/8693#issuecomment-5851057680
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8693?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 92.71%. Comparing base ([`33bd07b`](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`386d845`](https://app.codecov.io/gh/apache/texera/commit/386d845387c69e12e5d09745865825a20cf55813?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #8693 +/- ##
============================================
- Coverage 92.72% 92.71% -0.01%
Complexity 4947 4947
============================================
Files 1243 1242 -1
Lines 52682 52641 -41
Branches 6520 6514 -6
============================================
- Hits 48850 48808 -42
Misses 2214 2214
- Partials 1618 1619 +1
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `77.38% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `99.16% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `88.45% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.41% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `87.37% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `81.53% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.52% <100.00%> (-0.02%)` | :arrow_down: | |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `83.73% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `98.56% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8693/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `74.09% <ø> (ø)` | | Carriedforward from [33bd07b](https://app.codecov.io/gh/apache/texera/commit/33bd07bf27648870ecaf54da0d24c85763186cda?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8693?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org