You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2017/08/24 15:05:01 UTC
Review Request 61888: Add configurable management endpoints to Log
Search
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61888/
-----------------------------------------------------------
Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Sebastian Toader.
Bugs: AMBARI-21804
https://issues.apache.org/jira/browse/AMBARI-21804
Repository: ambari
Description
-------
Add actuator framework for Log Search, enable a few endpoints:
/ping - health checks, added some custom health indicators as well
/metrics - memory/threads etc. details for the application
/env - environment variables and properties for the app, (secrets/passwords/credentials are not visiable)
/heapdump + /dump endpoints
/auditevents - currently showing failed logins, needs to be extended later.
new api endpoint outside of the managment apis:
/api/v1/info - show logsearch/solr/java version details - ambari reads that from the new info.properties, which is filled during the maven build
Diffs
-----
ambari-logsearch/ambari-logsearch-server/pom.xml c0ae16e
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java 3d30c2a
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2758388
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java da0a8bb
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/AbstractSolrHealthIndicator.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrAuditLogsHealthIndicator.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrEventHistoryHealthIndicator.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrServiceLogsHealthIndicator.java PRE-CREATION
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java 2f63492
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java e49be90
ambari-logsearch/ambari-logsearch-server/src/main/resources/default.properties 4c74142
ambari-logsearch/ambari-logsearch-server/src/main/resources/info.properties PRE-CREATION
Diff: https://reviews.apache.org/r/61888/diff/1/
Testing
-------
done. manually
Thanks,
Oliver Szabo
Re: Review Request 61888: Add configurable management endpoints to
Log Search
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61888/#review183762
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Aug. 24, 2017, 5:05 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61888/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 5:05 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Sebastian Toader.
>
>
> Bugs: AMBARI-21804
> https://issues.apache.org/jira/browse/AMBARI-21804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add actuator framework for Log Search, enable a few endpoints:
> /ping - health checks, added some custom health indicators as well
> /metrics - memory/threads etc. details for the application
> /env - environment variables and properties for the app, (secrets/passwords/credentials are not visiable)
> /heapdump + /dump endpoints
> /auditevents - currently showing failed logins, needs to be extended later.
>
> new api endpoint outside of the managment apis:
> /api/v1/info - show logsearch/solr/java version details - ambari reads that from the new info.properties, which is filled during the maven build
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/pom.xml c0ae16e
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java 3d30c2a
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2758388
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java da0a8bb
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/AbstractSolrHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrAuditLogsHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrEventHistoryHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrServiceLogsHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java 2f63492
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java e49be90
> ambari-logsearch/ambari-logsearch-server/src/main/resources/default.properties 4c74142
> ambari-logsearch/ambari-logsearch-server/src/main/resources/info.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61888/diff/1/
>
>
> Testing
> -------
>
> done. manually
>
>
> Thanks,
>
> Oliver Szabo
>
>
Re: Review Request 61888: Add configurable management endpoints to
Log Search
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61888/#review183812
-----------------------------------------------------------
Ship it!
Ship It!
- Miklos Gergely
On Aug. 24, 2017, 3:05 p.m., Oliver Szabo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61888/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2017, 3:05 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Miklos Gergely, and Sebastian Toader.
>
>
> Bugs: AMBARI-21804
> https://issues.apache.org/jira/browse/AMBARI-21804
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add actuator framework for Log Search, enable a few endpoints:
> /ping - health checks, added some custom health indicators as well
> /metrics - memory/threads etc. details for the application
> /env - environment variables and properties for the app, (secrets/passwords/credentials are not visiable)
> /heapdump + /dump endpoints
> /auditevents - currently showing failed logins, needs to be extended later.
>
> new api endpoint outside of the managment apis:
> /api/v1/info - show logsearch/solr/java version details - ambari reads that from the new info.properties, which is filled during the maven build
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-server/pom.xml c0ae16e
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/ApplicationConfig.java 3d30c2a
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java 2758388
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java da0a8bb
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/AbstractSolrHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrAuditLogsHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrEventHistoryHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/health/SolrServiceLogsHealthIndicator.java PRE-CREATION
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/InfoManager.java 2f63492
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/InfoResource.java e49be90
> ambari-logsearch/ambari-logsearch-server/src/main/resources/default.properties 4c74142
> ambari-logsearch/ambari-logsearch-server/src/main/resources/info.properties PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61888/diff/1/
>
>
> Testing
> -------
>
> done. manually
>
>
> Thanks,
>
> Oliver Szabo
>
>