You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/01 09:01:38 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #8084: ARROW-9874: [C++] Add sink-owning version of IPC writers

pitrou commented on a change in pull request #8084:
URL: https://github.com/apache/arrow/pull/8084#discussion_r480983890



##########
File path: cpp/src/arrow/ipc/writer.cc
##########
@@ -1042,8 +1042,13 @@ class ARROW_EXPORT IpcFormatWriter : public RecordBatchWriter {
 
 class StreamBookKeeper {
  public:
-  explicit StreamBookKeeper(const IpcWriteOptions& options, io::OutputStream* sink)
+  StreamBookKeeper(const IpcWriteOptions& options, io::OutputStream* sink)
       : options_(options), sink_(sink), position_(-1) {}

Review comment:
       No, it's implicit (a `shared_ptr` is always initialized).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org