[GitHub] [tvm-vta] dsteger commented on a change in pull request #20: Enable Supported Xilinx target ZCU104 with Hardware Preset

[GitBox <gi...@apache.org>]

dsteger commented on a change in pull request #20:
URL: https://github.com/apache/tvm-vta/pull/20#discussion_r537829814



##########
File path: hardware/xilinx/scripts/vivado.tcl
##########
@@ -80,6 +82,11 @@ set store_ip "${ip_path}/vta_store/soln/impl/ip/xilinx_com_hls_store_1_0.zip"
 # Create custom project
 create_project -force $proj_name $proj_path -part $device
 
+# Apply board preset if exists
+if {$board != "None" && $board_rev != "None"} {
+  set_property BOARD_PART $board:$board_rev [current_project]

Review comment:
       When you build a hardware design Vivado let's you specify something called presets based on BOARD_PART. Presets are board specific configurations related to the hardware. Most importantly the DDR configuration. If you look at the hardware design built without a preset you will notice that the DDR defaults to 1600MHz. If you apply the preset (ZCU104 for this example) the DDR clock will be 2133MHZ.
   
   If we want meaningful output products then we should specify this for the boards. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org