You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by tinkoff-dwh <gi...@git.apache.org> on 2017/03/08 15:26:26 UTC
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2112
[ZEPPELIN-2228] precode for SparkRInterpreter
### What is this PR for?
Added parameter zeppelin.pyspark.precode to SparkRInterpreter. This is snippet of code which executes when interpreter initialize.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2228
### How should this be tested?
1. Set parameter zeppelin.R.precode precodeVar=1+2
2. Run
```
%r
print(precodeVar)
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit d758979ddf2c707df75fe4fdaa958865940a8a84
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T10:47:13Z
[ZEPPELIN-2228] precode for SparkR interpreter
commit 4ab2fdb02bfce59e3a89620bc3605b2bfd745787
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T14:41:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2228
commit 8323392a8d76becb75ddc0cb1c140174be3a8e90
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-08T13:03:18Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2228
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkRInterpreter.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by dgskv <gi...@git.apache.org>.
Github user dgskv commented on the issue:
https://github.com/apache/zeppelin/pull/2112
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2112
#2221 general solution
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh closed the pull request at:
https://github.com/apache/zeppelin/pull/2112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2112
[ZEPPELIN-2228] precode for SparkRInterpreter
### What is this PR for?
Added parameter zeppelin.pyspark.precode to SparkRInterpreter. This is snippet of code which executes when interpreter initialize.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2228
### How should this be tested?
1. Set parameter zeppelin.R.precode precodeVar=1+2
2. Run
```
%r
print(precodeVar)
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit d758979ddf2c707df75fe4fdaa958865940a8a84
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T10:47:13Z
[ZEPPELIN-2228] precode for SparkR interpreter
commit 4ab2fdb02bfce59e3a89620bc3605b2bfd745787
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T14:41:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2228
commit 8323392a8d76becb75ddc0cb1c140174be3a8e90
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-08T13:03:18Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2228
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkRInterpreter.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2112
Ready to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2112
CI green, https://travis-ci.org/tinkoff-dwh/zeppelin/builds/208970773 , commit is correct 8323392,
but status failed (tried reopen) failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
GitHub user tinkoff-dwh reopened a pull request:
https://github.com/apache/zeppelin/pull/2112
[ZEPPELIN-2228] precode for SparkRInterpreter
### What is this PR for?
Added parameter zeppelin.pyspark.precode to SparkRInterpreter. This is snippet of code which executes when interpreter initialize.
### What type of PR is it?
Feature
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2228
### How should this be tested?
1. Set parameter zeppelin.R.precode precodeVar=1+2
2. Run
```
%r
print(precodeVar)
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2228
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2112
----
commit d758979ddf2c707df75fe4fdaa958865940a8a84
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T10:47:13Z
[ZEPPELIN-2228] precode for SparkR interpreter
commit 4ab2fdb02bfce59e3a89620bc3605b2bfd745787
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-07T14:41:45Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2228
commit 8323392a8d76becb75ddc0cb1c140174be3a8e90
Author: Tinkoff DWH <ti...@gmail.com>
Date: 2017-03-08T13:03:18Z
Merge remote-tracking branch 'origin/master' into ZEPPELIN-2228
# Conflicts:
# spark/src/main/java/org/apache/zeppelin/spark/SparkRInterpreter.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2112
@echarles
https://issues.apache.org/jira/browse/ZEPPELIN-2216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2112
CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/208970773
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2112: [ZEPPELIN-2228] precode for SparkRInterpreter
Posted by echarles <gi...@git.apache.org>.
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/2112
Would be good to generalize this precode execution to all interprerters, having methods like `prerun`, `postrun`... at `Interpeter` interface level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---