[GitHub] [incubator-tvm] kimishpatel commented on a change in pull request #4243: Fix broken loop partitioning due to recent changes.

[GitBox <gi...@apache.org>]

kimishpatel commented on a change in pull request #4243: Fix broken loop partitioning due to recent changes.
URL: https://github.com/apache/incubator-tvm/pull/4243#discussion_r342390422
 
 

 ##########
 File path: src/pass/loop_partition.cc
 ##########
 @@ -513,17 +513,19 @@ Stmt LoopPartitioner::TryPartition(const Node* node,
   bool pre_stmt_recurse = true;
   if (middle_interval_i->HasLowerBound()) {
     body_begin = ir::Simplify(middle_interval.min());
-    Expr cond = (body_begin - min >= 0);
 
 Review comment:
   @umangyadav, I understand. Do you have specific example where we can still generate zero extent loops despite this PR? Then it will be easier to see what would be a better fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services