[GitHub] [cordova-android] brodybits commented on pull request #928: Update check_reqs.js - allow JDK > 1.8

[GitBox <gi...@apache.org>]

brodybits commented on pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#issuecomment-645023122


   As I said in [this thread on the mailing list([1])](https://lists.apache.org/thread.html/ra54447f23a6df77128dbec69ad3130281221e8a1b724c5ceb02052db%40%3Cdev.cordova.apache.org%3E), I was able to use OpenJDK 13 to build and install a couple of non-Cordova Android apps from the command line, including a React Native project. (OpenJDK 13 also worked for me with building and installing <https://github.com/sqlcipher/sqlcipher-android-tests> from the command line.)
   
   A side point is that we are using Gradle a little differently than most other Android projects, as discussed [in the same thread ([1])](https://lists.apache.org/thread.html/ra54447f23a6df77128dbec69ad3130281221e8a1b724c5ceb02052db%40%3Cdev.cordova.apache.org%3E).
   
   So yes, I think we should update to allow JDK > 1.8, properly, with proper review and testing. I took the liberty to update the title again to better reflect the actual change proposed here.
   
   [1] https://lists.apache.org/thread.html/ra54447f23a6df77128dbec69ad3130281221e8a1b724c5ceb02052db%40%3Cdev.cordova.apache.org%3E


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org