You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2009/01/27 15:36:59 UTC

[jira] Created: (SLING-843) Do not cut off potential servlet context path in SlingRequestDispatcher

Do not cut off potential servlet context path in SlingRequestDispatcher
-----------------------------------------------------------------------

                 Key: SLING-843
                 URL: https://issues.apache.org/jira/browse/SLING-843
             Project: Sling
          Issue Type: Bug
          Components: Engine
    Affects Versions: Engine 2.0.2
            Reporter: Felix Meschberger
            Assignee: Felix Meschberger
             Fix For: Engine 2.0.4


With SLING-221 (Rev. 618697) code has been added to the SlingRequestDispatcher to cut off the servlet context path if the path to include has the context path as a prefix.

According to my reading of the Servlet Spec, the absolute path used to retrieve a RequestDispatcher is interpreted relative to the servlet context, that is the path is never prefixed with any servlet context path. Hence cutting of some piece of the path is not correct.

Note, that the assumption of cutting off the context path is used throughout a number of integration tests. These tests will fail and have to be fixed when fixing this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-843) Do not cut off potential servlet context path in SlingRequestDispatcher

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger closed SLING-843.
-----------------------------------

    Resolution: Fixed

Removed this context path prefix removal and fixed the unit tests to not include the context path in the pathToInclude property in Rev. 738205.

> Do not cut off potential servlet context path in SlingRequestDispatcher
> -----------------------------------------------------------------------
>
>                 Key: SLING-843
>                 URL: https://issues.apache.org/jira/browse/SLING-843
>             Project: Sling
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: Engine 2.0.2
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Engine 2.0.4
>
>
> With SLING-221 (Rev. 618697) code has been added to the SlingRequestDispatcher to cut off the servlet context path if the path to include has the context path as a prefix.
> According to my reading of the Servlet Spec, the absolute path used to retrieve a RequestDispatcher is interpreted relative to the servlet context, that is the path is never prefixed with any servlet context path. Hence cutting of some piece of the path is not correct.
> Note, that the assumption of cutting off the context path is used throughout a number of integration tests. These tests will fail and have to be fixed when fixing this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.