You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/12 11:21:47 UTC

[GitHub] [arrow-datafusion] returnString commented on pull request #288: [Datafusion] NOW() function support

returnString commented on pull request #288:
URL: https://github.com/apache/arrow-datafusion/pull/288#issuecomment-839692218


   > I am not sure we should do this: we are changing all functions' signatures because of a single function's requirement.
   > 
   > I think we should add a node specifically for `NOW` and leave all the other functions' alone.
   
   We'll probably hit up against similar issues for current_date, current_time, current_timestamp, etc, in case that helps formulate what said node would look like.
   
   Interestingly, this is an instance where it would be much _easier_ if slightly less performant to implement as a UDF for certain use cases, because you could just close over some external state when building your execution ctx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org