You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/13 09:59:00 UTC
[GitHub] [inlong] liangyepianzhou opened a new pull request, #5879: [INLONG-5133][Sort] Support influxDB sink for sort
liangyepianzhou opened a new pull request, #5879:
URL: https://github.com/apache/inlong/pull/5879
### Prepare a Pull Request
- Fixes https://github.com/apache/inlong/issues/5133
### Motivation
Add influx DB sink for sort.
### Modifications
1. Implement the influxDBLoadNode
2. Implement the InfluxDBDialect
3. Move an influxDB-JDBC-driver into inlong, we can replace it when the influxDB supports JDBC.
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r973656231
##########
inlong-sort/sort-connectors/jdbc/src/main/java/com/wisecoders/dbschema/influxdb/InfluxResultSetMetaData.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.wisecoders.dbschema.influxdb;
+
+import com.influxdb.query.FluxRecord;
+
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Types;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Copyright Wise Coders GmbH https://wisecoders.com
+ * Driver is used in the DbSchema Database Designer https://dbschema.com
+ * Free to be used by everyone.
+ * Code modifications allowed only to GitHub repository https://github.com/wise-coders/influxdb-jdbc-driver
+ */
+
Review Comment:
This is an introduced third-party connector, we can only use it and cannot modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on PR #5879:
URL: https://github.com/apache/inlong/pull/5879#issuecomment-1249150734
Please handle the pipeline error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972651568
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
The Sort Connectors module contains all connectors or modules common to connectors. There is currently no official driver implementation for influx db. It is reasonable to put the corresponding driver implementation in the jdbc connector. When the official implementation is available later, remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] github-actions[bot] commented on pull request #5879: [INLONG-5133][Sort] Support InfluxDB load node and connector
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #5879:
URL: https://github.com/apache/inlong/pull/5879#issuecomment-1374346913
This PR is stale because it has been open for 60 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang closed pull request #5879: [INLONG-5133][Sort] Support InfluxDB load node and connector
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang closed pull request #5879: [INLONG-5133][Sort] Support InfluxDB load node and connector
URL: https://github.com/apache/inlong/pull/5879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r973833526
##########
inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/InfluxDBDialect.java:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.jdbc.dialect;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Optional;
+import org.apache.flink.connector.jdbc.internal.converter.JdbcRowConverter;
+import org.apache.flink.table.types.logical.LogicalTypeRoot;
+import org.apache.flink.table.types.logical.RowType;
+import org.apache.inlong.sort.jdbc.converter.influxdb.InfluxdbRowConverter;
+import org.apache.inlong.sort.jdbc.table.AbstractJdbcDialect;
+
+public class InfluxDBDialect extends AbstractJdbcDialect {
+
+ private static final long serialVersionUID = 1L;
+
+ // Define MAX/MIN precision of TIMESTAMP type according to influx docs:
+ // https://awesome.influxdata.com/docs/part-2/input-format-vs-output-format/#note-on-timestamp-precision
+ private static final int MAX_TIMESTAMP_PRECISION = 9;
+ private static final int MIN_TIMESTAMP_PRECISION = 1;
+
+ // Define MAX/MIN precision of DECIMAL type according to influx docs:
+ // https://docs.influxdata.com/influxdb/v2.4/reference/syntax/annotated-csv/
+ private static final int MAX_DECIMAL_PRECISION = 64;
+ private static final int MIN_DECIMAL_PRECISION = 1;
+
+ @Override
+ public int maxDecimalPrecision() {
+ return MAX_DECIMAL_PRECISION;
+ }
+
+ @Override
+ public int minDecimalPrecision() {
+ return MIN_DECIMAL_PRECISION;
+ }
+
+ @Override
+ public int maxTimestampPrecision() {
+ return MAX_TIMESTAMP_PRECISION;
+ }
+
+ @Override
+ public int minTimestampPrecision() {
+ return MIN_TIMESTAMP_PRECISION;
+ }
+
+ @Override
+ public List<LogicalTypeRoot> unsupportedTypes() {
+ //https://docs.influxdata.com/flux/v0.x/data-types/
+ return Arrays.asList(
+ LogicalTypeRoot.BINARY,
+ LogicalTypeRoot.TIMESTAMP_WITH_LOCAL_TIME_ZONE,
+ LogicalTypeRoot.TIMESTAMP_WITH_TIME_ZONE,
+ LogicalTypeRoot.INTERVAL_YEAR_MONTH,
+ LogicalTypeRoot.INTERVAL_DAY_TIME,
+ LogicalTypeRoot.ARRAY,
+ LogicalTypeRoot.MULTISET,
+ LogicalTypeRoot.MAP,
+ LogicalTypeRoot.ROW,
+ LogicalTypeRoot.DISTINCT_TYPE,
+ LogicalTypeRoot.STRUCTURED_TYPE,
+ LogicalTypeRoot.RAW,
+ LogicalTypeRoot.SYMBOL,
+ LogicalTypeRoot.UNRESOLVED);
+ }
+
+ @Override
+ public String dialectName() {
+ return "InfluxDB";
+ }
+
+ @Override
+ public boolean canHandle(String url) {
+ return url.startsWith("http");
Review Comment:
Make sure it is http protocol here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972589473
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
1. Name changes done.
2.` the package of jdbc/src/main... should not be under sort-connectors.`, do you mean `the package of influxdb-jdbc/src/main`. And please explain why this is wrong.
3. this CDC sues JDBC table API: `options.put("connector", "jdbc-inlong");`
4. @jun0315 is already testing the referenced influx-jdbc-driver connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972577506
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
influxdb -> influxdbLoad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972593293
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
2.If it is based on the jdbc connector extension, you can put the influxdb-jdbc code in the jdbc connector, there is no need to start a single module
3.If it already have the unit test, you can put the corresponding link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972712617
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/InfluxDBLoadNode.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.protocol.node.load;
+
+import javax.annotation.Nullable;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.NoArgsConstructor;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.inlong.sort.protocol.FieldInfo;
+import org.apache.inlong.sort.protocol.InlongMetric;
+import org.apache.inlong.sort.protocol.enums.FilterStrategy;
+import org.apache.inlong.sort.protocol.node.LoadNode;
+import org.apache.inlong.sort.protocol.transformation.FieldRelation;
+import org.apache.inlong.sort.protocol.transformation.FilterFunction;
+
+import java.io.Serializable;
+import java.util.List;
+import java.util.Map;
+import org.apache.inlong.sort.protocol.transformation.WatermarkField;
+
+/**
+ * influxDB load node can load data into InfluxDB.
+ */
+@EqualsAndHashCode(callSuper = true)
+@JsonTypeName("influxDBLoadNode")
Review Comment:
Keep JsonTypeName consistent between LoadNode,Node and InfluxDBLoadNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972673256
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/InfluxDBLoadNode.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.protocol.node.load;
+
+import javax.annotation.Nullable;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.NoArgsConstructor;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.inlong.sort.protocol.FieldInfo;
+import org.apache.inlong.sort.protocol.InlongMetric;
+import org.apache.inlong.sort.protocol.enums.FilterStrategy;
+import org.apache.inlong.sort.protocol.node.LoadNode;
+import org.apache.inlong.sort.protocol.transformation.FieldRelation;
+import org.apache.inlong.sort.protocol.transformation.FilterFunction;
+
+import java.io.Serializable;
+import java.util.List;
+import java.util.Map;
+import org.apache.inlong.sort.protocol.transformation.WatermarkField;
+
+/**
+ * influxDB load node can load data into InfluxDB.
+ */
+@EqualsAndHashCode(callSuper = true)
+@JsonTypeName("influxDBLoadNode")
Review Comment:
influxDBLoadNode -> influxdbLoad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] liangyepianzhou commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972641320
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/LoadNode.java:
##########
@@ -72,7 +73,8 @@
@JsonSubTypes.Type(value = OracleLoadNode.class, name = "oracleLoad"),
@JsonSubTypes.Type(value = GreenplumLoadNode.class, name = "greenplumLoad"),
@JsonSubTypes.Type(value = DLCIcebergLoadNode.class, name = "dlcIcebergLoad"),
- @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad")
+ @JsonSubTypes.Type(value = DorisLoadNode.class, name = "dorisLoad"),
+ @JsonSubTypes.Type(value = InfluxDBLoadNode.class, name = "influxdb")
Review Comment:
> 2.If it is based on the jdbc connector extension, you can put the influxdb-jdbc code in the jdbc connector, there is no need to start a single module
I have a problem with this, this is a jdbc-driver. rather than a jdbc table API. The JDBC-connector module calls the influx-jdbc-driver module. When the influx jdbc driver is officially supported, we should delete this module and replace it with a new jdbc-driver. Writing them together not only makes no sense but also increases code coupling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gong commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
gong commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972572495
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/InfluxDBLoadNode.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.sort.protocol.node.load;
+
+import javax.annotation.Nullable;
+import lombok.Data;
+import lombok.EqualsAndHashCode;
+import lombok.NoArgsConstructor;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.annotation.JsonTypeName;
+import org.apache.inlong.sort.protocol.FieldInfo;
+import org.apache.inlong.sort.protocol.InlongMetric;
+import org.apache.inlong.sort.protocol.enums.FilterStrategy;
+import org.apache.inlong.sort.protocol.node.LoadNode;
+import org.apache.inlong.sort.protocol.transformation.FieldRelation;
+import org.apache.inlong.sort.protocol.transformation.FilterFunction;
+
+import java.io.Serializable;
+import java.util.List;
+import java.util.Map;
+import org.apache.inlong.sort.protocol.transformation.WatermarkField;
+
+/**
+ * MySql load node can load data into MySql
+ */
Review Comment:
description is error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5879: [INLONG-5133][Sort] Support influxDB sink for sort
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5879:
URL: https://github.com/apache/inlong/pull/5879#discussion_r972693508
##########
inlong-sort/sort-connectors/jdbc/src/main/java/com/wisecoders/dbschema/influxdb/InfluxResultSetMetaData.java:
##########
@@ -0,0 +1,200 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.wisecoders.dbschema.influxdb;
+
+import com.influxdb.query.FluxRecord;
+
+import java.sql.ResultSetMetaData;
+import java.sql.SQLException;
+import java.sql.Types;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Copyright Wise Coders GmbH https://wisecoders.com
+ * Driver is used in the DbSchema Database Designer https://dbschema.com
+ * Free to be used by everyone.
+ * Code modifications allowed only to GitHub repository https://github.com/wise-coders/influxdb-jdbc-driver
+ */
+
Review Comment:
extra blank space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] github-actions[bot] commented on pull request #5879: [INLONG-5133][Sort] Support InfluxDB load node and connector
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5879:
URL: https://github.com/apache/inlong/pull/5879#issuecomment-1496811133
This PR is stale because it has been open for 60 days with no activity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org