[GitHub] [dubbo] namelessssssssssss commented on a diff in pull request #12948: Split DefaultConfigValidator to SPI implements

["namelessssssssssss (via GitHub)" <gi...@apache.org>]

namelessssssssssss commented on code in PR #12948:
URL: https://github.com/apache/dubbo/pull/12948#discussion_r1314847363


##########
dubbo-common/src/main/java/org/apache/dubbo/common/constants/CommonConstants.java:
##########
@@ -337,6 +337,8 @@ public interface CommonConstants {
 
     String REGISTRY_PROTOCOL_LISTENER_KEY = "registry.protocol.listener";
 
+    String REGISTRY_SERVICE_CLASS_NAME = "org.apache.dubbo.registry.RegistryService";

Review Comment:
   This constant used to replace direct reference of `RegistryService` in `ConfigValidationUtils`
   
   Old:
   ```Java
   //ConfigValidationUtils.loadRegistries:214
                       map.put(PATH_KEY, RegistryService.class.getName());
   ```
   
   New:
   ```Java
   //ConfigValidationUtils.loadRegistries:127
                       map.put(PATH_KEY,REGISTRY_SERVICE_CLASS_NAME);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org