svn commit: r554377 - /maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java

[de...@apache.org]

Author: dennisl
Date: Sun Jul  8 08:49:25 2007
New Revision: 554377

URL: http://svn.apache.org/viewvc?view=rev&rev=554377
Log:
o Make sure that the body of an element is returned fully, excluding any surrounding whitespace but including any entities.
o Use the summary instead of the comments as the action.

Modified:
    maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java

Modified: maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java?view=diff&rev=554377&r1=554376&r2=554377
==============================================================================
--- maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java (original)
+++ maven/plugins/trunk/maven-changes-plugin/src/main/java/org/apache/maven/plugin/announcement/JiraAnnouncementParser.java Sun Jul  8 08:49:25 2007
@@ -33,7 +33,9 @@
 import org.xml.sax.helpers.DefaultHandler;
 
 /**
- * XML Parser for <code>JiraAnnouncement</code>s.
+ * XML Parser for <code>JiraAnnouncement</code>s. This works on an XML file
+ * downloaded from JIRA and creates a List of issues that is exposed to the
+ * user of the class. It can also extract a List of releases from such issues.
  *
  * @author aramirez@exist.com
  * @version $Id$
@@ -91,6 +93,8 @@
     public void endElement( String namespaceURI, String sName, String qName )
         throws SAXException
     {
+        elementValue = elementValue.trim();
+        
         if ( qName.equals( "item" ) )
         {
             issues.add( issue );
@@ -141,6 +145,8 @@
         {
             issue.addComment( elementValue );
         }
+        
+        elementValue = "";
     }
 
     public void characters( char[] buff, int offset, int len )
@@ -148,12 +154,7 @@
     {
         String str = new String( buff, offset, len );
 
-        String string = str.trim();
-
-        if ( !string.equals( "" ) )
-        {
-            elementValue = string;
-        }
+        elementValue += str;
     }
 
     public List getIssues()
@@ -216,16 +217,7 @@
 
         //action.setDueTo( issue.getReporter() );
 
-        if ( issue.getComments() != null && !issue.getComments().isEmpty() )
-        {
-            int commentSize = issue.getComments().size();
-
-            action.setAction( issue.getComments().get( commentSize - 1 ).toString() );
-        }
-        else
-        {
-            action.setAction( "" );
-        }
+        action.setAction( issue.getSummary() );
         return action;
     }
 }