You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/09/27 20:44:09 UTC

Review Request 14375: Fixed formatting log output in signal handler.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14375/
-----------------------------------------------------------

Review request for mesos, Ben Mahler and Vinson Lee.


Bugs: MESOS-710
    https://issues.apache.org/jira/browse/MESOS-710


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  src/logging/logging.cpp 49a804cab7cfcc9092338f930d28b520487c8b59 

Diff: https://reviews.apache.org/r/14375/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Re: Review Request 14375: Fixed formatting log output in signal handler.

Posted by Vinson Lee <vl...@freedesktop.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14375/#review26436
-----------------------------------------------------------

Ship it!


This is the identical patch I submitted in MESOS-710.

Tested-by: Vinson Lee <vl...@twitter.com>

- Vinson Lee


On Sept. 27, 2013, 6:44 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14375/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 6:44 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinson Lee.
> 
> 
> Bugs: MESOS-710
>     https://issues.apache.org/jira/browse/MESOS-710
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.cpp 49a804cab7cfcc9092338f930d28b520487c8b59 
> 
> Diff: https://reviews.apache.org/r/14375/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Re: Review Request 14375: Fixed formatting log output in signal handler.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14375/#review26439
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Sept. 27, 2013, 6:44 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14375/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2013, 6:44 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinson Lee.
> 
> 
> Bugs: MESOS-710
>     https://issues.apache.org/jira/browse/MESOS-710
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/logging/logging.cpp 49a804cab7cfcc9092338f930d28b520487c8b59 
> 
> Diff: https://reviews.apache.org/r/14375/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>