[GitHub] [spark] cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI store assignment policy: throw exception on casting failure

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #25997: [SPARK-29326][SQL] ANSI store assignment policy: throw exception on casting failure
URL: https://github.com/apache/spark/pull/25997#discussion_r330440215
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
 ##########
 @@ -256,10 +256,13 @@ object Cast {
       > SELECT _FUNC_('10' as int);
        10
   """)
-case class Cast(child: Expression, dataType: DataType, timeZoneId: Option[String] = None)
-  extends UnaryExpression with TimeZoneAwareExpression with NullIntolerant {
+abstract class CastBase extends UnaryExpression with TimeZoneAwareExpression with NullIntolerant {
+
+  def child: Expression
+
+  def dataType: DataType
 
-  def this(child: Expression, dataType: DataType) = this(child, dataType, None)
+  def timeZoneId: Option[String]
 
 Review comment:
   This is already declared in the parent class `TimeZoneAwareExpression`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org