You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/11 22:52:09 UTC

[GitHub] [geode] DonalEvans commented on a diff in pull request #7579: GEODE-10161: Remove unnecessary synchronization from RedisList

DonalEvans commented on code in PR #7579:
URL: https://github.com/apache/geode/pull/7579#discussion_r847799209


##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java:
##########
@@ -265,7 +267,7 @@ public void lset(Region<RedisKey, RedisData> region, RedisKey key, int index, by
       throw new RedisException(ERROR_INDEX_OUT_OF_RANGE);
     }
 
-    elementReplace(adjustedIndex, value);
+    elementList.set(adjustedIndex, value);

Review Comment:
   This call is not inside a synchronized block but modifies the backing list. Is there a possibility of issues here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org