You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Matt Juntunen (Jira)" <ji...@apache.org> on 2021/07/10 12:10:00 UTC

[jira] [Resolved] (NUMBERS-166) SortInPlace should not implement BiConsumer

     [ https://issues.apache.org/jira/browse/NUMBERS-166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Juntunen resolved NUMBERS-166.
-----------------------------------
    Resolution: Done

> SortInPlace should not implement BiConsumer
> -------------------------------------------
>
>                 Key: NUMBERS-166
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-166
>             Project: Commons Numbers
>          Issue Type: Improvement
>            Reporter: Matt Juntunen
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The {{SortInPlace}} enum uses a varargs in the method signature that is not compatible with the {{BiConsumer}} interface that it implements. The interface implementation should be removed and the sort method renamed from {{accept}} to {{apply}} to better reflect that the arguments are being modified.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)