You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Pavel Pervov <pm...@gmail.com> on 2008/02/18 15:50:37 UTC
[approval] Commit HARMONY-5501
I'd like to commit HARMONY-5501. This is the regression since M4 and
thus should be fixed.
Still the fix is pretty local.
Thanks,
Pavel.
Re: [approval] Commit HARMONY-5501
Posted by Alexei Fedotov <al...@gmail.com>.
I would suggest improving the patch with the appropriate comment.
Taking a reminder from a division of double numbers does not seem an
obvious practice.
On Feb 18, 2008 5:50 PM, Pavel Pervov <pm...@gmail.com> wrote:
> I'd like to commit HARMONY-5501. This is the regression since M4 and
> thus should be fixed.
>
> Still the fix is pretty local.
>
> Thanks,
> Pavel.
>
--
With best regards,
Alexei
Re: [approval] Commit HARMONY-5501
Posted by Mikhail Markov <mi...@gmail.com>.
+1 for committing and adding an appropriate comment to the code as well as
regression test.
Thanks,
Mikhail
On 2/18/08, Pavel Pervov <pm...@gmail.com> wrote:
>
> I'd like to commit HARMONY-5501. This is the regression since M4 and
> thus should be fixed.
>
> Still the fix is pretty local.
>
> Thanks,
> Pavel.
>
Re: [approval] Commit HARMONY-5501
Posted by Vladimir Beliaev <vl...@gmail.com>.
-1 for confusion...
2008/2/18, Alexei Fedotov <al...@gmail.com>:
>
> Pavel,
> I'm sorry for my mental instability, I confused this bug with a
> different one and decided that this is some hack about division.
> Thanks.
>
>
> On Feb 18, 2008 7:38 PM, Pavel Pervov <pm...@gmail.com> wrote:
> > Alexei,
> >
> > What is the problem with "a reminder from a division of double numbers"?
> >
> > JLS reads: "In C and C++, the remainder operator accepts only integral
> > operands, but in the Java programming language, it also accepts
> > floating-point operands."
> >
> > I assumed that JLS is the basics of Java and thus used that construct
> > as common knowledge...
> >
> > WBR,
> > Pavel.
> >
> >
> > On 2/18/08, Alexei Fedotov <al...@gmail.com> wrote:
> > > -1 to commit of unreadable code
> > >
> > > On Feb 18, 2008 5:56 PM, Alexey Petrenko <al...@gmail.com>
> wrote:
> > > > +1 for commit
> > > >
> > > > 2008/2/18, Pavel Pervov <pm...@gmail.com>:
> > > >
> > > > > I'd like to commit HARMONY-5501. This is the regression since M4
> and
> > > > > thus should be fixed.
> > > > >
> > > > > Still the fix is pretty local.
> > > > >
> > > > > Thanks,
> > > > > Pavel.
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > With best regards,
> > > Alexei
> > >
> >
>
>
>
> --
> With best regards,
> Alexei
>
--
Vladimir Beliaev
Intel Middleware Products Division
Re: [approval] Commit HARMONY-5501
Posted by Alexei Fedotov <al...@gmail.com>.
Pavel,
I'm sorry for my mental instability, I confused this bug with a
different one and decided that this is some hack about division.
Thanks.
On Feb 18, 2008 7:38 PM, Pavel Pervov <pm...@gmail.com> wrote:
> Alexei,
>
> What is the problem with "a reminder from a division of double numbers"?
>
> JLS reads: "In C and C++, the remainder operator accepts only integral
> operands, but in the Java programming language, it also accepts
> floating-point operands."
>
> I assumed that JLS is the basics of Java and thus used that construct
> as common knowledge...
>
> WBR,
> Pavel.
>
>
> On 2/18/08, Alexei Fedotov <al...@gmail.com> wrote:
> > -1 to commit of unreadable code
> >
> > On Feb 18, 2008 5:56 PM, Alexey Petrenko <al...@gmail.com> wrote:
> > > +1 for commit
> > >
> > > 2008/2/18, Pavel Pervov <pm...@gmail.com>:
> > >
> > > > I'd like to commit HARMONY-5501. This is the regression since M4 and
> > > > thus should be fixed.
> > > >
> > > > Still the fix is pretty local.
> > > >
> > > > Thanks,
> > > > Pavel.
> > > >
> > >
> >
> >
> >
> > --
> > With best regards,
> > Alexei
> >
>
--
With best regards,
Alexei
Re: [approval] Commit HARMONY-5501
Posted by Pavel Pervov <pm...@gmail.com>.
Alexei,
What is the problem with "a reminder from a division of double numbers"?
JLS reads: "In C and C++, the remainder operator accepts only integral
operands, but in the Java programming language, it also accepts
floating-point operands."
I assumed that JLS is the basics of Java and thus used that construct
as common knowledge...
WBR,
Pavel.
On 2/18/08, Alexei Fedotov <al...@gmail.com> wrote:
> -1 to commit of unreadable code
>
> On Feb 18, 2008 5:56 PM, Alexey Petrenko <al...@gmail.com> wrote:
> > +1 for commit
> >
> > 2008/2/18, Pavel Pervov <pm...@gmail.com>:
> >
> > > I'd like to commit HARMONY-5501. This is the regression since M4 and
> > > thus should be fixed.
> > >
> > > Still the fix is pretty local.
> > >
> > > Thanks,
> > > Pavel.
> > >
> >
>
>
>
> --
> With best regards,
> Alexei
>
Re: [approval] Commit HARMONY-5501
Posted by Alexei Fedotov <al...@gmail.com>.
-1 to commit of unreadable code
On Feb 18, 2008 5:56 PM, Alexey Petrenko <al...@gmail.com> wrote:
> +1 for commit
>
> 2008/2/18, Pavel Pervov <pm...@gmail.com>:
>
> > I'd like to commit HARMONY-5501. This is the regression since M4 and
> > thus should be fixed.
> >
> > Still the fix is pretty local.
> >
> > Thanks,
> > Pavel.
> >
>
--
With best regards,
Alexei
Re: [approval] Commit HARMONY-5501
Posted by Alexey Petrenko <al...@gmail.com>.
+1 for commit
2008/2/18, Pavel Pervov <pm...@gmail.com>:
> I'd like to commit HARMONY-5501. This is the regression since M4 and
> thus should be fixed.
>
> Still the fix is pretty local.
>
> Thanks,
> Pavel.
>