You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/09/10 03:05:22 UTC

[GitHub] [incubator-shenyu] yu199195 opened a new pull request #2050: [type: refactor] refactor sign api

yu199195 opened a new pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050


   // Describe your PR here; eg. Fixes #issueNo
   
   <!--
   Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
   -->
   Make sure that:
   
   - [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor).
   - [ ] You submit test cases (unit or integration tests) that back your changes.
   - [ ] Your local test passed `mvn clean install -Dmaven.javadoc.skip=true`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de590cd) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.33%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head de590cd differs from pull request most recent head 365d4b7. Consider uploading reports for the commit 365d4b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.72%   +0.33%     
   - Complexity     4011     4026      +15     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10786      +63     
   + Misses         6161     6101      -60     
   - Partials        872      874       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `60.00% <0.00%> (+2.00%)` | :arrow_up: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `64.21% <0.00%> (+4.21%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (365d4b7) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.57%   +0.18%     
   - Complexity     4011     4023      +12     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10759      +36     
   + Misses         6161     6127      -34     
   - Partials        872      875       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `72.72% <0.00%> (+1.81%)` | :arrow_up: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (+10.29%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (365d4b7) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.49%   +0.10%     
   - Complexity     4011     4022      +11     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10745      +22     
   + Misses         6161     6139      -22     
   - Partials        872      877       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `72.72% <0.00%> (+1.81%)` | :arrow_up: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `72.81% <0.00%> (+9.70%)` | :arrow_up: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `36.76% <0.00%> (+10.29%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de590cd) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.11%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head de590cd differs from pull request most recent head 365d4b7. Consider uploading reports for the commit 365d4b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.50%   +0.11%     
   - Complexity     4011     4017       +6     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10746      +23     
   + Misses         6161     6141      -20     
   - Partials        872      874       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `33.82% <0.00%> (+7.35%)` | :arrow_up: |
   | [...che/shenyu/sync/data/http/HttpSyncDataService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1odHRwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2h0dHAvSHR0cFN5bmNEYXRhU2VydmljZS5qYXZh) | `71.84% <0.00%> (+8.73%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (365d4b7) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.27%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.66%   +0.27%     
   - Complexity     4011     4028      +17     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10774      +51     
   + Misses         6161     6111      -50     
   - Partials        872      876       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `72.72% <0.00%> (+1.81%)` | :arrow_up: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `64.21% <0.00%> (+4.21%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de590cd) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **decrease** coverage by `0.30%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head de590cd differs from pull request most recent head 365d4b7. Consider uploading reports for the commit 365d4b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   - Coverage     60.39%   60.08%   -0.31%     
   + Complexity     4011     4000      -11     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1693       -1     
   ============================================
   - Hits          10723    10672      -51     
   - Misses         6161     6225      +64     
   + Partials        872      864       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...org/apache/shenyu/admin/utils/ThreadLocalUtil.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvVGhyZWFkTG9jYWxVdGlsLmphdmE=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
   | [...apache/shenyu/admin/transfer/MetaDataTransfer.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdHJhbnNmZXIvTWV0YURhdGFUcmFuc2Zlci5qYXZh) | `34.56% <0.00%> (-65.44%)` | :arrow_down: |
   | [...a/org/apache/shenyu/common/utils/VersionUtils.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9WZXJzaW9uVXRpbHMuamF2YQ==) | `67.85% <0.00%> (-10.72%)` | :arrow_down: |
   | [...in/response/strategy/NettyClientMessageWriter.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc3BvbnNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3Jlc3BvbnNlL3N0cmF0ZWd5L05ldHR5Q2xpZW50TWVzc2FnZVdyaXRlci5qYXZh) | `69.56% <0.00%> (-4.35%)` | :arrow_down: |
   | [...che/shenyu/admin/model/vo/SelectorConditionVO.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbW9kZWwvdm8vU2VsZWN0b3JDb25kaXRpb25WTy5qYXZh) | `96.07% <0.00%> (-1.97%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (365d4b7) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.21%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.60%   +0.21%     
   - Complexity     4011     4025      +14     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10764      +41     
   + Misses         6161     6121      -40     
   - Partials        872      876       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `72.72% <0.00%> (+1.81%)` | :arrow_up: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `44.11% <0.00%> (+17.64%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] SaberSola merged pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
SaberSola merged pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de590cd) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.22%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head de590cd differs from pull request most recent head 365d4b7. Consider uploading reports for the commit 365d4b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.61%   +0.22%     
   - Complexity     4011     4020       +9     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10766      +43     
   + Misses         6161     6119      -42     
   - Partials        872      876       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `64.21% <0.00%> (+4.21%)` | :arrow_up: |
   | [...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jbGllbnQvU2hlbnl1R3JwY0NsaWVudC5qYXZh) | `13.04% <0.00%> (+4.34%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (365d4b7) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.36%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.75%   +0.36%     
   - Complexity     4011     4031      +20     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10791      +68     
   + Misses         6161     6095      -66     
   - Partials        872      875       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...t/zookeeper/ZookeeperClientRegisterRepository.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXJlZ2lzdGVyLWNlbnRlci9zaGVueXUtcmVnaXN0ZXItY2xpZW50L3NoZW55dS1yZWdpc3Rlci1jbGllbnQtem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcmVnaXN0ZXIvY2xpZW50L3pvb2tlZXBlci9ab29rZWVwZXJDbGllbnRSZWdpc3RlclJlcG9zaXRvcnkuamF2YQ==) | `72.72% <0.00%> (+1.81%)` | :arrow_up: |
   | [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `60.00% <0.00%> (+2.00%)` | :arrow_up: |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #2050: [type: refactor] refactor sign api

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2050:
URL: https://github.com/apache/incubator-shenyu/pull/2050#issuecomment-916599123


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2050](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de590cd) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/e2a1c6709570de5bda5b7de287f4a2dc48236630?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2a1c67) will **increase** coverage by `0.23%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head de590cd differs from pull request most recent head 365d4b7. Consider uploading reports for the commit 365d4b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2050      +/-   ##
   ============================================
   + Coverage     60.39%   60.62%   +0.23%     
   - Complexity     4011     4022      +11     
   ============================================
     Files           604      606       +2     
     Lines         17756    17761       +5     
     Branches       1694     1694              
   ============================================
   + Hits          10723    10768      +45     
   + Misses         6161     6119      -42     
   - Partials        872      874       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/shenyu/plugin/sign/SignPlugin.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9TaWduUGx1Z2luLmphdmE=) | `50.00% <ø> (ø)` | |
   | [...he/shenyu/plugin/sign/api/DefaultSignProvider.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvRGVmYXVsdFNpZ25Qcm92aWRlci5qYXZh) | `100.00% <ø> (ø)` | |
   | [...shenyu/plugin/sign/api/ShenyuSignProviderWrap.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9hcGkvU2hlbnl1U2lnblByb3ZpZGVyV3JhcC5qYXZh) | `66.66% <ø> (ø)` | |
   | [...shenyu/plugin/sign/service/DefaultSignService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNpZ24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc2lnbi9zZXJ2aWNlL0RlZmF1bHRTaWduU2VydmljZS5qYXZh) | `75.00% <ø> (ø)` | |
   | [...t/starter/plugin/sign/SignPluginConfiguration.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXIvc2hlbnl1LXNwcmluZy1ib290LXN0YXJ0ZXItcGx1Z2luL3NoZW55dS1zcHJpbmctYm9vdC1zdGFydGVyLXBsdWdpbi1zaWduL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3ByaW5nYm9vdC9zdGFydGVyL3BsdWdpbi9zaWduL1NpZ25QbHVnaW5Db25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...henyu/admin/service/impl/UpstreamCheckService.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL1Vwc3RyZWFtQ2hlY2tTZXJ2aWNlLmphdmE=) | `26.82% <0.00%> (+4.06%)` | :arrow_up: |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `64.21% <0.00%> (+4.21%)` | :arrow_up: |
   | [...he/shenyu/plugin/grpc/client/ShenyuGrpcClient.java](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9jbGllbnQvU2hlbnl1R3JwY0NsaWVudC5qYXZh) | `13.04% <0.00%> (+4.34%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/incubator-shenyu/pull/2050/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e2a1c67...365d4b7](https://codecov.io/gh/apache/incubator-shenyu/pull/2050?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org