You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/09/11 09:20:35 UTC
[GitHub] [incubator-doris] stdpain commented on a change in pull request #6622: refactor olap_scan_node: discard boost, remove dynamic_cast
stdpain commented on a change in pull request #6622:
URL: https://github.com/apache/incubator-doris/pull/6622#discussion_r706587901
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -620,16 +616,10 @@ Status OlapScanNode::normalize_conjuncts() {
Status OlapScanNode::build_olap_filters() {
for (auto& iter : _column_value_ranges) {
- ToOlapFilterVisitor visitor;
- boost::variant<std::vector<TCondition>> filters;
- boost::apply_visitor(visitor, iter.second, filters);
-
- std::vector<TCondition> new_filters = boost::get<std::vector<TCondition>>(filters);
- if (new_filters.empty()) {
- continue;
- }
+ std::vector<TCondition> filters;
+ std::visit([&](auto &&range) { range.to_olap_filter(filters); }, iter.second);
- for (const auto& filter : new_filters) {
+ for (const auto& filter : filters) {
_olap_filter.push_back(filter);
Review comment:
```suggestion
for (auto& filter : filters) {
_olap_filter.emplace_back(std::move(filter));
}
```
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -620,16 +616,10 @@ Status OlapScanNode::normalize_conjuncts() {
Status OlapScanNode::build_olap_filters() {
for (auto& iter : _column_value_ranges) {
- ToOlapFilterVisitor visitor;
- boost::variant<std::vector<TCondition>> filters;
- boost::apply_visitor(visitor, iter.second, filters);
-
- std::vector<TCondition> new_filters = boost::get<std::vector<TCondition>>(filters);
- if (new_filters.empty()) {
- continue;
- }
+ std::vector<TCondition> filters;
+ std::visit([&](auto &&range) { range.to_olap_filter(filters); }, iter.second);
- for (const auto& filter : new_filters) {
+ for (const auto& filter : filters) {
_olap_filter.push_back(filter);
Review comment:
use move instead of copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org