You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/11/13 07:34:59 UTC

[apreq-2] glue/perl cookie test

Hi,
   With the current cvs, I get a failure in a couple
of the glue/perl cookie tests, due to some warnings
about uninitialized values. This diff:
======================================================
Index: t/response/TestApreq/cookie.pm
===================================================================
RCS file: /home/cvs/httpd-apreq-2/glue/perl/t/response/TestApReq/cookie.pm,v
retrieving revision 1.8
diff -u -r1.8 cookie.pm
--- t/response/TestApreq/cookie.pm	13 Nov 2003 04:05:20 -0000	1.8
+++ t/response/TestApreq/cookie.pm	13 Nov 2003 06:34:46 -0000
@@ -20,7 +20,7 @@
     my $test = $req->param('test');
     my $key  = $req->param('key');

-    if ($cookies{$key}) {
+    if ($key and $cookies{$key}) {
         if ($test eq "bake") {
             $cookies{$key}->bake;
         }
==============================================================
fixes that.

-- 
best regards,
randy

Re: [apreq-2] glue/perl cookie test

Posted by Joe Schaefer <jo...@sunstarsys.com>.
Randy Kobes <ra...@theoryx5.uwinnipeg.ca> writes:

> Hi,
>    With the current cvs, I get a failure in a couple
> of the glue/perl cookie tests, due to some warnings
> about uninitialized values. This diff:
> ======================================================
> Index: t/response/TestApreq/cookie.pm
> ===================================================================
> RCS file: /home/cvs/httpd-apreq-2/glue/perl/t/response/TestApReq/cookie.pm,v
> retrieving revision 1.8
> diff -u -r1.8 cookie.pm
> --- t/response/TestApreq/cookie.pm	13 Nov 2003 04:05:20 -0000	1.8
> +++ t/response/TestApreq/cookie.pm	13 Nov 2003 06:34:46 -0000
> @@ -20,7 +20,7 @@
>      my $test = $req->param('test');
>      my $key  = $req->param('key');
> 
> -    if ($cookies{$key}) {
> +    if ($key and $cookies{$key}) {
>          if ($test eq "bake") {
>              $cookies{$key}->bake;
>          }
> ==============================================================
> fixes that.

Thanks, applied.

-- 
Joe Schaefer