[GitHub] [airflow] bbovenzi commented on a diff in pull request #29944: Fix tags selection in DAGs UI

["bbovenzi (via GitHub)" <gi...@apache.org>]

bbovenzi commented on code in PR #29944:
URL: https://github.com/apache/airflow/pull/29944#discussion_r1128088111


##########
airflow/www/static/js/dags.js:
##########
@@ -61,9 +61,10 @@ $("#tags_filter").select2({
 $("#tags_filter").on("change", (e) => {
   e.preventDefault();
   const query = new URLSearchParams(window.location.search);
-  if (e.val.length) {

Review Comment:
   This issue is because those tags are not actually on the page, so all we need to do is update this check, right?
   
   `if (e.val && e.val.length) {`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org