[jira] [Commented] (NIFI-4987) Support TTL in Redis

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481965#comment-16481965 ] 

ASF GitHub Bot commented on NIFI-4987:
--------------------------------------

GitHub user zenfenan opened a pull request:

    https://github.com/apache/nifi/pull/2726

    NIFI-4987: Added TTL to RedisDistributedMapCacheClientService

    **Note to reviewers**
    
    I have replaced the original `getAndPutIfAbsent` with a new approach. `setNX` doesn't take TTL so I modified the function to do this: check `exists(key)` is false then `set(key, value)`. Do let me know, if there are any concerns.
    
    ---
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zenfenan/nifi NIFI-4987

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2726
    
----
commit df5c3cf2c1d7b7f6989e2a9d4c2fa1c52b09833c
Author: zenfenan <si...@...>
Date:   2018-05-20T13:52:26Z

    NIFI-4987: Added TTL to RedisDistributedMapCacheClientService

----


> Support TTL in Redis
> --------------------
>
>                 Key: NIFI-4987
>                 URL: https://issues.apache.org/jira/browse/NIFI-4987
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Brian Ghigiarelli
>            Assignee: Sivaprasanna Sethuraman
>            Priority: Minor
>
> To properly integrate the NiFi with Redis, it would be nice to support setting TTLs for keys, whether a global TTL is used for the particular Redis database, or a configurable TTL is used for each key. At the moment, the PutDistributedMapCache processor that uses the RedisDistributedMapCacheClientService and calls to the RedisConnectionPoolService does not pass in any TTL / EXPIRE parameter, so Redis will cache the value potentially forever unless Redis itself clears the key based on its configured maxmemory eviction strategy.
> On [SO|https://stackoverflow.com/questions/49321005/setting-ttl-on-redis-with-apache-nifi-putdistributedmapcache/49324205#49324205], [~bbende] suggested either a PutRedis processor or a modification to the RedisDistributedMapCacheClientService.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)