You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/24 06:38:25 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1402: fix TestClusterMaintenanceMode.testMaintenanceHistory
kaisun2000 opened a new issue #1402:
URL: https://github.com/apache/helix/issues/1402
LOG 1349
>2020-09-24T05:57:40.9661144Z [ERROR] testMaintenanceHistory(org.apache.helix.integration.controller.TestClusterMaintenanceMode) Time elapsed: 0.012 s <<< FAILURE!
2020-09-24T05:57:40.9663283Z java.lang.AssertionError: expected:< ENTER> but was:< EXIT>
2020-09-24T05:57:40.9666348Z at org.apache.helix.integration.controller.TestClusterMaintenanceMode.testMaintenanceHistory(TestClusterMaintenanceMode.java:345)
2020-09-24T05:57:40.9673712Z
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang closed issue #1402: fix TestClusterMaintenanceMode.testMaintenanceHistory
Posted by GitBox <gi...@apache.org>.
jiajunwang closed issue #1402:
URL: https://github.com/apache/helix/issues/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1402: fix TestClusterMaintenanceMode.testMaintenanceHistory
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1402:
URL: https://github.com/apache/helix/issues/1402#issuecomment-698147299
```
@Test(dependsOnMethods = "testMaxPartitionLimit")
public void testMaintenanceHistory() throws InterruptedException, IOException {
// In maintenance mode, by controller, for MAX_PARTITION_PER_INSTANCE_EXCEEDED
ControllerHistory history = _dataAccessor.getProperty(_keyBuilder.controllerLeaderHistory());
Map<String, String> lastHistoryEntry = convertStringToMap(
history.getMaintenanceHistoryList().get(history.getMaintenanceHistoryList().size() - 1));
// **The KV pairs are hard-coded in here for the ease of reading!**
Assert.assertEquals(lastHistoryEntry.get("OPERATION_TYPE"), "ENTER"); -----> this line failed.
Assert.assertEquals(lastHistoryEntry.get("TRIGGERED_BY"), "CONTROLLER");
Assert.assertEquals(lastHistoryEntry.get("AUTO_TRIGGER_REASON"),
"MAX_PARTITION_PER_INSTANCE_EXCEEDED");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1402: fix TestClusterMaintenanceMode.testMaintenanceHistory
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1402:
URL: https://github.com/apache/helix/issues/1402#issuecomment-698147299
```
@Test(dependsOnMethods = "testMaxPartitionLimit")
public void testMaintenanceHistory() throws InterruptedException, IOException {
// In maintenance mode, by controller, for MAX_PARTITION_PER_INSTANCE_EXCEEDED
ControllerHistory history = _dataAccessor.getProperty(_keyBuilder.controllerLeaderHistory());
Map<String, String> lastHistoryEntry = convertStringToMap(
history.getMaintenanceHistoryList().get(history.getMaintenanceHistoryList().size() - 1));
// **The KV pairs are hard-coded in here for the ease of reading!**
Assert.assertEquals(lastHistoryEntry.get("OPERATION_TYPE"), "ENTER"); -----> this line failed.
Assert.assertEquals(lastHistoryEntry.get("TRIGGERED_BY"), "CONTROLLER");
Assert.assertEquals(lastHistoryEntry.get("AUTO_TRIGGER_REASON"),
"MAX_PARTITION_PER_INSTANCE_EXCEEDED");
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on issue #1402: fix TestClusterMaintenanceMode.testMaintenanceHistory
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on issue #1402:
URL: https://github.com/apache/helix/issues/1402#issuecomment-849105124
Close test unstable tickets since we have an automatic tracking mechanism https://github.com/apache/helix/pull/1757 now for tracking the most recent test issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org