[GitHub] [jackrabbit-oak] stefan-egli commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

[GitBox <gi...@apache.org>]

stefan-egli commented on PR #690:
URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1254002255

   Regarding the "two separate metrics" question: I think there's two different layers to this question: a code design and a metric design question. I've only had a quick look at the PR now, so my comment is only about the metric design.
   
   So only regarding that: IIUC then the state of the PR now already does have the two metrics separate. Except that it has the throttling time representing the sum of mongo time plus throttling time. And that could be something to discuss: do we want the metric to represent the sum, or only the throttling time. I think it might be easier if it was only the throttling time (but actually, we might provide all 3 :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org