You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hc.apache.org by pmouawad <gi...@git.apache.org> on 2017/02/21 22:30:52 UTC

[GitHub] httpclient pull request #65: Make some package protected classes public as w...

GitHub user pmouawad opened a pull request:

    https://github.com/apache/httpclient/pull/65

    Make some package protected classes public as we need to extend them in current jmeter

    Hello,
    Would it be possible to make those classes public as for now in JMeter, to use validation mechanism introduced in 4.3 we had to create a custom class located in  package "org.apache.http.impl.conn" which is clearly a hack.
    In the future we will probably migrate directly to HttpClient5.
    
    Thanks

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pmouawad/httpclient make_public

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/httpclient/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 1756bdc6d6b6991e7dbce385fa100f11b70c989f
Author: PhilM <ph...@10.1.112.167>
Date:   2017-02-21T22:30:58Z

    Make some package protected classes public as we need to extend them

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] httpclient issue #65: Make some package protected classes public as we need ...

Posted by ok2c <gi...@git.apache.org>.

Github user ok2c commented on the issue:

    https://github.com/apache/httpclient/pull/65
  
    +1 to @fxbonnet's comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[GitHub] httpclient issue #65: Make some package protected classes public as we need ...

Posted by pmouawad <gi...@git.apache.org>.

Github user pmouawad commented on the issue:

https://github.com/apache/httpclient/pull/65

@ok2c , @fxbonnet , I am aware of the fact that classes are deprecated, see how we use them and the javadocs:

- https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java

Doing what you propose means for me copy/pasting the 3 classes in JMeter, which I don't find it better.
Migrating fully to 4.5 new code is identified:

- https://bz.apache.org/bugzilla/show_bug.cgi?id=58757

Still, the migration is not a little piece of cake and for us does not bring enough ROI to be done.
JMeter relied on "advanced" api of HC4 and although I know you make a lot of effort, documentation for migration was not complete at all for such parts.

@ok2c helped a lot on Cookie migration which was important feature for us. We're using new APIs for new code , like Async Backend Listener that interracts with InfluxDB, but as you know we have to make some choice as time is not infinite :-)

In the future and if possible, it would be nice when you deprecate an API to mention in javadoc its new class equivalent. It's not done everywhere.

As Http2 is expected in 5.0, for now I must say I prefer to do migration at that time.

But @ok2c if you don't want to merge the PR, I'll do that.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org