[GitHub] [spark] cloud-fan commented on a change in pull request #30354: [SPARK-33140][SQL][FOLLOW-UP] change val to def in object rule

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30354:
URL: https://github.com/apache/spark/pull/30354#discussion_r522055220



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveHints.scala
##########
@@ -51,9 +51,9 @@ object ResolveHints {
    * This rule must happen before common table expressions.
    */
   object ResolveJoinStrategyHints extends Rule[LogicalPlan] {
-    private val STRATEGY_HINT_NAMES = JoinStrategyHint.strategies.flatMap(_.hintAliases)
+    private def STRATEGY_HINT_NAMES = JoinStrategyHint.strategies.flatMap(_.hintAliases)

Review comment:
       will this change with config?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org