You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/09/08 10:14:30 UTC
[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4659
[FLINK-4047] Fix documentation about determinism of KeySelectors
## What is the purpose of the change
This PR fixes the incorrect description for `KeySelectors`.
## Brief change log
- Correct `api_concepts.md` file, make `arbitrary computations` to `deterministic computations`.
- Update JavaDoc of `KeySelector `class
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-4047
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4659.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4659
----
commit ad54e76fd804c9ae18c5403872b5d3e26d51a266
Author: zhangminglei <zm...@163.com>
Date: 2017-09-08T10:04:28Z
[FLINK-4047] Fix documentation about determinism of KeySelectors
----
---
[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4659
---
[GitHub] flink issue #4659: [FLINK-4047] Fix documentation about determinism of KeySe...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4659
I think this LGTM. Will merge this ..
---
[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4659#discussion_r138918167
--- Diff: flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java ---
@@ -36,7 +37,7 @@
public interface KeySelector<IN, KEY> extends Function, Serializable {
/**
- * User-defined function that extracts the key from an arbitrary object.
+ * User-defined function that extracts the key from an deterministic object.
--- End diff --
I think this should be `User-defined function that deterministically extracts the key from an object.`
---
[GitHub] flink issue #4659: [FLINK-4047] Fix documentation about determinism of KeySe...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4659
+1.
---
[GitHub] flink pull request #4659: [FLINK-4047] Fix documentation about determinism o...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4659#discussion_r139048412
--- Diff: flink-core/src/main/java/org/apache/flink/api/java/functions/KeySelector.java ---
@@ -36,7 +37,7 @@
public interface KeySelector<IN, KEY> extends Function, Serializable {
/**
- * User-defined function that extracts the key from an arbitrary object.
+ * User-defined function that extracts the key from an deterministic object.
--- End diff --
Okay. Thanks. I will correct it soon.
---