[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6355: [HUDI-4925] Should Force to use ExpressionPayload in MergeIntoTableCommand

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #6355:
URL: https://github.com/apache/hudi/pull/6355#discussion_r980509048


##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -508,6 +507,6 @@ case class MergeIntoHoodieTableCommand(mergeInto: MergeIntoTable) extends Hoodie
         SqlKeyGenerator.PARTITION_SCHEMA -> partitionSchema.toDDL
       )
         .filter { case (_, v) => v != null }
-    }
+    } + (PAYLOAD_CLASS_NAME.key -> classOf[ExpressionPayload].getCanonicalName)

Review Comment:
   No need to append it here -- you can prepend to `catalogProperties` above.
   Let's also add a comment explaining why this is put in here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org