You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by jtstorck <gi...@git.apache.org> on 2017/02/24 01:11:53 UTC
[GitHub] nifi pull request #1539: NIFI-3520 Updates classloading for components annot...
GitHub user jtstorck opened a pull request:
https://github.com/apache/nifi/pull/1539
NIFI-3520 Updates classloading for components annotated with Requires\u2026
\u2026InstanceClassLoading to include dependencies in the InstanceClassLoader
Added RequiresInstanceClassLoading annotation to AbstractHadoopProcessor and HiveConnectionPool
Removed RequiresInstanceClassLoading from PutHDFS now that the AbstractHadoopProcessor uses the annotation
UGI relogins are now performed using doAs
Added debug-level logging for UGI relogins in KerberosTicketRenewer and AbstractHadoopProcessor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jtstorck/nifi NIFI-3520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1539
----
commit 9d91e60641f3ec528786f7add2ec878a8ad56173
Author: Jeff Storck <jt...@gmail.com>
Date: 2017-02-24T01:03:40Z
NIFI-3520 Updates classloading for components annotated with RequiresInstanceClassLoading to include dependencies in the InstanceClassLoader
Added RequiresInstanceClassLoading annotation to AbstractHadoopProcessor and HiveConnectionPool
Removed RequiresInstanceClassLoading from PutHDFS now that the AbstractHadoopProcessor uses the annotation
UGI relogins are now performed using doAs
Added debug-level logging for UGI relogins in KerberosTicketRenewer and AbstractHadoopProcessor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1539: NIFI-3520 Updates classloading for components annot...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1539: NIFI-3520 Updates classloading for components annot...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1539#discussion_r103770451
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/ExtensionManager.java ---
@@ -199,8 +199,20 @@ public static ClassLoader getClassLoader(final String classType, final String in
// then make a new InstanceClassLoader that is a full copy of the NAR Class Loader, otherwise create an empty
// InstanceClassLoader that has the NAR ClassLoader as a parent
if (requiresInstanceClassLoading.contains(classType) && (registeredClassLoader instanceof URLClassLoader)) {
- final URLClassLoader registeredUrlClassLoader = (URLClassLoader) registeredClassLoader;
- instanceClassLoader = new InstanceClassLoader(instanceIdentifier, classType, registeredUrlClassLoader.getURLs(), registeredUrlClassLoader.getParent());
+ final Set<URL> classLoaderResources = new HashSet<>();
+
+ // if the registered class loader is a NAR class loader then walk the chain of class loaders until
+ // finding a non-NAR class loader, and build up a list of all URLs along the way
+ while (registeredClassLoader != null && registeredClassLoader instanceof NarClassLoader) {
+ final NarClassLoader narClassLoader = (NarClassLoader) registeredClassLoader;
+ for (URL classLoaderResource : narClassLoader.getURLs()) {
+ classLoaderResources.add(classLoaderResource);
+ }
+ registeredClassLoader = narClassLoader.getParent();
+ }
--- End diff --
@olegz This PR will be updated with a different approach. This change will be reverted, overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1539: NIFI-3520 Updates classloading for components annot...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1539#discussion_r103750596
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/ExtensionManager.java ---
@@ -199,8 +199,20 @@ public static ClassLoader getClassLoader(final String classType, final String in
// then make a new InstanceClassLoader that is a full copy of the NAR Class Loader, otherwise create an empty
// InstanceClassLoader that has the NAR ClassLoader as a parent
if (requiresInstanceClassLoading.contains(classType) && (registeredClassLoader instanceof URLClassLoader)) {
- final URLClassLoader registeredUrlClassLoader = (URLClassLoader) registeredClassLoader;
- instanceClassLoader = new InstanceClassLoader(instanceIdentifier, classType, registeredUrlClassLoader.getURLs(), registeredUrlClassLoader.getParent());
+ final Set<URL> classLoaderResources = new HashSet<>();
+
+ // if the registered class loader is a NAR class loader then walk the chain of class loaders until
+ // finding a non-NAR class loader, and build up a list of all URLs along the way
+ while (registeredClassLoader != null && registeredClassLoader instanceof NarClassLoader) {
+ final NarClassLoader narClassLoader = (NarClassLoader) registeredClassLoader;
+ for (URL classLoaderResource : narClassLoader.getURLs()) {
+ classLoaderResources.add(classLoaderResource);
+ }
+ registeredClassLoader = narClassLoader.getParent();
+ }
--- End diff --
Perhaps this logic belongs in ```org.apache.nifi.util.file.classloader.ClassLoaderUtils```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1539: NIFI-3520 Updates classloading for components annotated wi...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1539
+1 going to merge to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---