[GitHub] [helix] pkuwm commented on a change in pull request #883: Support enableCompression in workflow and job configs

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #883: Support enableCompression in workflow and job configs
URL: https://github.com/apache/helix/pull/883#discussion_r391247879
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
 ##########
 @@ -552,6 +559,11 @@ public Builder setConfigMap(Map<String, String> cfg) {
         }
       }
 
+      if (cfg.containsKey(ZNRecord.ENABLE_COMPRESSION_BOOLEAN_FIELD)) {
 
 Review comment:
   No need to check containsKey, unless the default value enableCompression is true.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org