You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/06/04 21:45:01 UTC

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver 

Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13514


Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................

Add option to set driver in ImpalaJdbcDriver

ImpalaJdbcDriver is a simple class that provides a wrapper around the
Hive Jdbc driver for use in testing. This patch adds a '-d' parameter
that takes a driver class and executes queries with that driver
instead of the Hive driver, if its in the classpath.

This makes it easy to use ./bin/run-jdbc-client.sh to test other
Jdbc drivers, such as the proprietary Cloudera Impala driver.

Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
---
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
1 file changed, 25 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/13514/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 2:

Yeah, it was a draft, should be published now


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:17:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 4: Code-Review+2

gvo failure was unrelated


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jun 2019 16:24:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................

Add option to set driver in ImpalaJdbcDriver

ImpalaJdbcDriver is a simple class that provides a wrapper around the
Hive Jdbc driver for use in testing. This patch adds a '-d' parameter
that takes a driver class and executes queries with that driver
instead of the Hive driver, if its in the classpath.

This makes it easy to use ./bin/run-jdbc-client.sh to test other
Jdbc drivers, such as the proprietary Cloudera Impala driver.

Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
---
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
1 file changed, 26 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/14/13514/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:17:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4433/


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jun 2019 04:53:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3509/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 04 Jun 2019 22:25:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4433/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:17:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jun 2019 21:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................

Add option to set driver in ImpalaJdbcDriver

ImpalaJdbcDriver is a simple class that provides a wrapper around the
Hive Jdbc driver for use in testing. This patch adds a '-d' parameter
that takes a driver class and executes queries with that driver
instead of the Hive driver, if its in the classpath.

This makes it easy to use ./bin/run-jdbc-client.sh to test other
Jdbc drivers, such as the proprietary Cloudera Impala driver.

Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Reviewed-on: http://gerrit.cloudera.org:8080/13514
Reviewed-by: Thomas Marshall <tm...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/testutil/ImpalaJdbcClient.java
1 file changed, 26 insertions(+), 14 deletions(-)

Approvals:
  Thomas Marshall: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 1:

For some reason I can't +2 this - maybe there's a hidden draft patch or something?


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:11:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3547/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:56:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4437/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 Jun 2019 16:24:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Add option to set driver in ImpalaJdbcDriver

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13514 )

Change subject: Add option to set driver in ImpalaJdbcDriver
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6c8cec2f61e76b7c8321c954eef830778d8a8ee
Gerrit-Change-Number: 13514
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 23:13:20 +0000
Gerrit-HasComments: No