[jira] [Comment Edited] (CASSANDRA-17225) Add a virtual table for exposing batch metrics

["Ekaterina Dimitrova (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470986#comment-17470986 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-17225 at 1/8/22, 3:36 AM:
--------------------------------------------------------------------------

Hi Michael,

I noticed you added a PR. Is it ready for review or you are still working on it? Also, please, let me know if you want me to run CI for you? If you are done, please, move the ticket to Patch Available or even better Needs Committer to trigger the attention of potential reviewers. Thank you!


was (Author: e.dimitrova):
Hi Michael,

I noticed you added a PR. Is it ready for review or you are still working on it? Also, please, let me know if you want me to run CI for you?

> Add a virtual table for exposing batch metrics
> ----------------------------------------------
>
>                 Key: CASSANDRA-17225
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17225
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Benjamin Lerer
>            Assignee: Michael Burman
>            Priority: Normal
>              Labels: AdventCalendar2021, lhf
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are some existing metrics within BatchMetrics that provide metrics about related to the different types of Batches being executed. We should expose those through a virtual table.
> +Additional information for newcomers:+
> A new class should be created for representing the new Virtual Table in {{org.apache.cassandra.db.virtual}}. You can look at {{ThreadPoolsTable}} for an example of virtual table implementation and to {{TableMetricTables}} for how Histogram metrics can be exposed. The new table will need to be registered in {{SystemViewsKeyspace}}.
> Some unit tests should be added. For some example of virtual table tests you can look at {{SystemPropertiesTableTest}}.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org