You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nemo.apache.org by GitBox <gi...@apache.org> on 2018/11/01 12:24:52 UTC

[GitHub] johnyangk commented on issue #142: [NEMO-257] Local combining only for BinaryCombineFn

johnyangk commented on issue #142: [NEMO-257] Local combining only for BinaryCombineFn
URL: https://github.com/apache/incubator-nemo/pull/142#issuecomment-435024747
 
 
   @taegeonum and I had a chat. 
   
   The right way to do this seems to be to dig out the `Accumulators` from `Combine`s  to be used in local combiners and aggregation trees, and make the final reducer `mergeAccumulators()`  like Flink:
   
   https://github.com/apache/beam/blob/master/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/AbstractFlinkCombineRunner.java
   
   I'll close this issue, and create a new one to implement the new design. Thanks @taegeonum for the advice!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services