You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/09/13 19:26:24 UTC
[PR] [SPARK-59473] Support top-level `Decimal` decoding in `DataFrame.collect(as:)` [spark-connect-swift]
dongjoon-hyun opened a new pull request, #560:
URL: https://github.com/apache/spark-connect-swift/pull/560
### What changes were proposed in this pull request?
This PR aims to support top-level `Decimal` decoding in `DataFrame.collect(as:)`.
### Why are the changes needed?
Foundation's `Decimal.init(from:)` requests a keyed container of its internal fields. So, the following throws `ArrowError.invalid("Column for key \"exponent\" not found")`, while Scala `as[BigDecimal]` returns `1.50`.
```swift
try await spark.sql("SELECT CAST(1.5 AS DECIMAL(10,2)) AS v").collect(as: Decimal.self)
```
### Does this PR introduce _any_ user-facing change?
Yes. `collect(as: Decimal.self)` and `collect(as: Decimal?.self)` now return values instead of throwing errors.
### How was this patch tested?
Pass the CIs with the updated `CreateDataFrameTests.collectAsDecimal`.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59473] Support top-level `Decimal` decoding in `DataFrame.collect(as:)` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #560: [SPARK-59473] Support top-level `Decimal` decoding in `DataFrame.collect(as:)`
URL: https://github.com/apache/spark-connect-swift/pull/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59473] Support top-level `Decimal` decoding in `DataFrame.collect(as:)` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #560:
URL: https://github.com/apache/spark-connect-swift/pull/560#issuecomment-5655622289
Thank you so much always for your prompt help, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59473] Support top-level `Decimal` decoding in `DataFrame.collect(as:)` [spark-connect-swift]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #560:
URL: https://github.com/apache/spark-connect-swift/pull/560#issuecomment-5655664554
Merged to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org