You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/17 14:48:57 UTC

[GitHub] ZiyueHuang commented on a change in pull request #9468: standard adam update for sparse tensor

ZiyueHuang commented on a change in pull request #9468: standard adam update for sparse tensor
URL: https://github.com/apache/incubator-mxnet/pull/9468#discussion_r162071405
 
 

 ##########
 File path: tests/python/unittest/test_optimizer.py
 ##########
 @@ -520,10 +520,10 @@ def test_adam():
                                     not kwarg['multi_precision'])):
                             continue
                         compare_optimizer(opt1(**kwarg), opt2(**kwarg), shape, dtype)
-                        if (default_context() == mx.cpu()):
-                            compare_optimizer(opt1(sparse_update=True, **kwarg), opt2(**kwarg), shape,
 
 Review comment:
   Any particular reasons to only test sparse adam on cpu?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services