Re: [PR] Keep Campaign Manager delete report provision check in __init__ [airflow]

["mitre88 (via GitHub)" <gi...@apache.org>]

mitre88 commented on PR #70530:
URL: https://github.com/apache/airflow/pull/70530#issuecomment-5272427935

   Hi @potiuk — the rework is on the head (`64cd61f5`) and addresses the requested changes:
   
   - **Provision check kept in `__init__`** (per #70296): `if not exactly_one(report_name is not None, report_id is not None): raise ValueError(...)` in `DeleteReportOperator.__init__`, so missing/conflicting parameters fail at DAG construction time. A rendered `None` at execute time can no longer false-positive the check.
   - **Test rewritten constructor-based**: the parametrized test builds the operator directly (no attribute assignment), covers both missing and conflicting report params, and asserts `delete_report` is never invoked.
   - **`ValueError` narrowing** applied; the corresponding entries were removed from `generated/known_airflow_exceptions.txt` and `validate_operators_init_exemptions.txt`.
   
   Could you take another look when you have a moment? Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org