You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/09 04:26:01 UTC
[GitHub] [pulsar] Jason918 commented on a change in pull request #13827: Non-persistent topic subscription metrics
Jason918 commented on a change in pull request #13827:
URL: https://github.com/apache/pulsar/pull/13827#discussion_r802258382
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/NamespaceStatsAggregator.java
##########
@@ -174,37 +174,73 @@ private static void getTopicStats(Topic topic, TopicStats stats, boolean include
}
});
- tStatus.subscriptions.forEach((subName, subscriptionStats) -> {
- stats.subscriptionsCount++;
- stats.msgBacklog += subscriptionStats.msgBacklog;
-
- AggregatedSubscriptionStats subsStats = stats.subscriptionStats
- .computeIfAbsent(subName, k -> new AggregatedSubscriptionStats());
- subsStats.msgBacklog = subscriptionStats.msgBacklog;
- subsStats.msgDelayed = subscriptionStats.msgDelayed;
- subsStats.msgRateExpired = subscriptionStats.msgRateExpired;
- subsStats.totalMsgExpired = subscriptionStats.totalMsgExpired;
- subsStats.msgBacklogNoDelayed = subsStats.msgBacklog - subsStats.msgDelayed;
- subsStats.lastExpireTimestamp = subscriptionStats.lastExpireTimestamp;
- subsStats.lastAckedTimestamp = subscriptionStats.lastAckedTimestamp;
- subsStats.lastConsumedFlowTimestamp = subscriptionStats.lastConsumedFlowTimestamp;
- subsStats.lastConsumedTimestamp = subscriptionStats.lastConsumedTimestamp;
- subsStats.lastMarkDeleteAdvancedTimestamp = subscriptionStats.lastMarkDeleteAdvancedTimestamp;
- subscriptionStats.consumers.forEach(cStats -> {
- stats.consumersCount++;
- subsStats.unackedMessages += cStats.unackedMessages;
- subsStats.msgRateRedeliver += cStats.msgRateRedeliver;
- subsStats.msgRateOut += cStats.msgRateOut;
- subsStats.msgThroughputOut += cStats.msgThroughputOut;
- subsStats.bytesOutCounter += cStats.bytesOutCounter;
- subsStats.msgOutCounter += cStats.msgOutCounter;
- if (!subsStats.blockedSubscriptionOnUnackedMsgs && cStats.blockedConsumerOnUnackedMsgs) {
- subsStats.blockedSubscriptionOnUnackedMsgs = true;
- }
+ if (topic instanceof PersistentTopic) {
+ tStatus.subscriptions.forEach((subName, subscriptionStats) -> {
+ stats.subscriptionsCount++;
+ stats.msgBacklog += subscriptionStats.msgBacklog;
+
+ AggregatedSubscriptionStats subsStats = stats.subscriptionStats
+ .computeIfAbsent(subName, k -> new AggregatedSubscriptionStats());
+ subsStats.msgBacklog = subscriptionStats.msgBacklog;
+ subsStats.msgDelayed = subscriptionStats.msgDelayed;
+ subsStats.msgRateExpired = subscriptionStats.msgRateExpired;
+ subsStats.totalMsgExpired = subscriptionStats.totalMsgExpired;
+ subsStats.msgBacklogNoDelayed = subsStats.msgBacklog - subsStats.msgDelayed;
+ subsStats.lastExpireTimestamp = subscriptionStats.lastExpireTimestamp;
+ subsStats.lastAckedTimestamp = subscriptionStats.lastAckedTimestamp;
+ subsStats.lastConsumedFlowTimestamp = subscriptionStats.lastConsumedFlowTimestamp;
+ subsStats.lastConsumedTimestamp = subscriptionStats.lastConsumedTimestamp;
+ subsStats.lastMarkDeleteAdvancedTimestamp = subscriptionStats.lastMarkDeleteAdvancedTimestamp;
+ subscriptionStats.consumers.forEach(cStats -> {
+ stats.consumersCount++;
+ subsStats.unackedMessages += cStats.unackedMessages;
+ subsStats.msgRateRedeliver += cStats.msgRateRedeliver;
+ subsStats.msgRateOut += cStats.msgRateOut;
+ subsStats.msgThroughputOut += cStats.msgThroughputOut;
+ subsStats.bytesOutCounter += cStats.bytesOutCounter;
+ subsStats.msgOutCounter += cStats.msgOutCounter;
+ if (!subsStats.blockedSubscriptionOnUnackedMsgs && cStats.blockedConsumerOnUnackedMsgs) {
+ subsStats.blockedSubscriptionOnUnackedMsgs = true;
+ }
+ });
+ stats.rateOut += subsStats.msgRateOut;
+ stats.throughputOut += subsStats.msgThroughputOut;
});
- stats.rateOut += subsStats.msgRateOut;
- stats.throughputOut += subsStats.msgThroughputOut;
- });
+ } else {
+ ((NonPersistentTopicStatsImpl) tStatus).getNonPersistentSubscriptions()
Review comment:
Seems a lot of duplicated codes, what's difference between them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org