You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 04:31:52 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
amaliujia opened a new pull request, #38278:
URL: https://github.com/apache/spark/pull/38278
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Refactor `test_connect_plan_only.py` and move common code to base class.
2. Test `toProto` for `filter` and `alias`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
3. If you fix a bug, you can clarify why it is a bug.
-->
Improve python client testing coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996634683
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +63,23 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect) # type: ignore
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
+ return "internal_name"
+
@classmethod
def setUpClass(cls: Any) -> None:
cls.connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
Review Comment:
ah yes.
I will follow up. Python side testing framework needs more refinement for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38278:
URL: https://github.com/apache/spark/pull/38278#issuecomment-1281753706
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996634961
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +63,23 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect) # type: ignore
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
Review Comment:
done. I thought `mypy` checks such case but it seems not to be true on this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38278:
URL: https://github.com/apache/spark/pull/38278#issuecomment-1281096039
thinking my local mypy is different...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38278:
URL: https://github.com/apache/spark/pull/38278#issuecomment-1280272483
R: @HyukjinKwon @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996607118
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +60,18 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect)
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
+ return "internal_name"
+
@classmethod
def setUpClass(cls: Any) -> None:
cls.connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+
+ cls.connect.set_hook("register_udf", cls._udf_mock)
+ cls.connect.set_hook("readTable", cls._read_table)
Review Comment:
I think we should also drop the table and udf at `teardownClass`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996627047
##########
python/pyspark/testing/connectutils.py:
##########
@@ -47,6 +49,9 @@ def __init__(self) -> None:
def set_hook(self, name: str, hook: Any) -> None:
self.hooks[name] = hook
+ def drop_hook(self, name: str) -> None:
+ self.hooks.pop(name)
Review Comment:
should we catch the exceptions if `self.hooks` do not contains `name`?
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +63,23 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect) # type: ignore
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
Review Comment:
nit:
```suggestion
def _udf_mock(cls, *args, **kwargs) -> str:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996629632
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +63,23 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect) # type: ignore
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
+ return "internal_name"
+
@classmethod
def setUpClass(cls: Any) -> None:
cls.connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
Review Comment:
We shouldn't actually use uuid here but call `DROP IF EXISTS` before and after running the tests. Since this PR doesn't target to address these, I am fine with doing separately too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996634199
##########
python/pyspark/testing/connectutils.py:
##########
@@ -47,6 +49,9 @@ def __init__(self) -> None:
def set_hook(self, name: str, hook: Any) -> None:
self.hooks[name] = hook
+ def drop_hook(self, name: str) -> None:
+ self.hooks.pop(name)
Review Comment:
This is only for our testing and we have good control over it (e.g. make sure we only clean up things that registered for the testing) so I think it is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38278:
URL: https://github.com/apache/spark/pull/38278#issuecomment-1281091699
wired that seeing
```
Run PYTHON_EXECUTABLE=python3.9 ./dev/lint-python
starting python compilation test...
python compilation succeeded.
starting black test...
black checks passed.
starting flake8 test...
flake8 checks passed.
starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/sql/connect/plan.py:325: error: unused "type: ignore" comment
python/pyspark/sql/connect/plan.py:327: error: unused "type: ignore" comment
python/pyspark/sql/connect/plan.py:331: error: unused "type: ignore" comment
python/pyspark/sql/connect/plan.py:342: error: unused "type: ignore" comment
python/pyspark/sql/connect/plan.py:346: error: unused "type: ignore" comment
python/pyspark/sql/connect/plan.py:348: error: unused "type: ignore" comment
Found 6 errors in 1 file (checked 366 source files)
1
```
not seeing this from local mypy check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38278:
URL: https://github.com/apache/spark/pull/38278#issuecomment-1280477801
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38278:
URL: https://github.com/apache/spark/pull/38278#discussion_r996614296
##########
python/pyspark/testing/connectutils.py:
##########
@@ -58,7 +60,18 @@ class PlanOnlyTestFixture(unittest.TestCase):
connect: "MockRemoteSession"
+ @classmethod
+ def _read_table(cls, table_name: str) -> "DataFrame":
+ return DataFrame.withPlan(Read(table_name), cls.connect)
+
+ @classmethod
+ def _udf_mock(cls, *args, **kwargs):
+ return "internal_name"
+
@classmethod
def setUpClass(cls: Any) -> None:
cls.connect = MockRemoteSession()
cls.tbl_name = f"tbl{uuid.uuid4()}".replace("-", "")
+
+ cls.connect.set_hook("register_udf", cls._udf_mock)
+ cls.connect.set_hook("readTable", cls._read_table)
Review Comment:
makes sense. done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38278: [SPARK-40809][SPARK-40780][FOLLOW-UP] Improve filter and alias testing coverage in python client
URL: https://github.com/apache/spark/pull/38278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org