You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/02 12:43:09 UTC
[GitHub] [airflow] potiuk opened a new pull request #16775: Switches to ghcr.io container registry
potiuk opened a new pull request #16775:
URL: https://github.com/apache/airflow/pull/16775
After fixing permission problems, we can now switch to ghcr.io
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872997655
I got My PR working in my fork so merging this one https://github.com/potiuk/airflow/pull/157/checks?check_run_id=2972629813 (and proceed with permanent removal of package registry once we see ghcr.io succeeding for PRs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872992364
> Static check job does not use `pull_request_target` workflow though I thought: https://github.com/apache/airflow/pull/16775/checks?check_run_id=2972416770#step:10:28
It can use both. It is (for transition period) implemented in the way that it will use either of the two - it tries to see which one is pushed and uses this one once we merge and prove that it works there is a follow up PR to remove whole lot of complexity of this "dual registry" support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872986609
> Hmm CI doesn’t seem to work
> Error response from daemon: Get https://docker.pkg.github.com/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Yeah. That's why I pushed it. Seems that the legacy GitHub Packages again having problems and I just fixed permission problems yesterday with `ghcr.io` so we should merge that one (note - we have to merge it "believing" that it will work).
I run two builds to test it in my fork:
* Main build: https://github.com/potiuk/airflow/actions/runs/993622080
* PR build from another account (waiting to see it works): https://github.com/potiuk/airflow/pull/157/checks?check_run_id=2972490378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872990868
> > Although why is it using docker.pkg in CI currently, shouldn't it be using ghcr.io?
>
> Because it will only work after merge to main :) (pull_request_target workflow uses main version of the workflow)
Static check job does not use `pull_request_target` workflow though I thought: https://github.com/apache/airflow/pull/16775/checks?check_run_id=2972416770#step:10:28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16775:
URL: https://github.com/apache/airflow/pull/16775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872986091
>Error response from daemon: Get https://docker.pkg.github.com/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Yeah weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872989697
> Although why is it using docker.pkg in CI currently, shouldn't it be using ghcr.io?
Because it will only work after merge to main :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872989697
> Although why is it using docker.pkg in CI currently, shouldn't it be using ghcr.io?
Because it will only work after merge to main :) (pull_request_target workflow uses `main` version of the workflow)
That's why I am testing it in my fork where I pushed it as "main" branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872989697
> Although why is it using docker.pkg in CI currently, shouldn't it be using ghcr.io?
Because it will only work after merge to main :) (pull_request_target workflow uses main version of the workflow)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872993056
So this build had a chance of succeding (but the legacy package registry fails currently)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872981672
Hmm CI doesn’t seem to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872986091
>Error response from daemon: Get https://docker.pkg.github.com/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Yeah weird
Although why is it using docker.pkg in CI currently, shouldn't it be using ghcr.io?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872986091
Error response from daemon: Get https://docker.pkg.github.com/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Yeah weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872986609
> Hmm CI doesn’t seem to work
> Error response from daemon: Get https://docker.pkg.github.com/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
Yeah. That's why I pushed it. Seems that the legacy GitHub Packages again having problems and I just fixed permission problem with `ghcr.io` so we should merge that one (note - we have to merge it "believing" that it will work).
I run two builds to test it in my fork:
* Main build: https://github.com/potiuk/airflow/actions/runs/993622080
* PR build from another account (waiting to see it works): https://github.com/potiuk/airflow/pull/157/checks?check_run_id=2972490378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16775: Switches to ghcr.io container registry
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16775:
URL: https://github.com/apache/airflow/pull/16775#issuecomment-872996350
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org