[GitHub] Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #4298: [AIRFLOW-3478] Make sure that the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r244725505
 
 

 ##########
 File path: airflow/bin/cli.py
 ##########
 @@ -423,14 +418,11 @@ def unpause(args, dag=None):
 def set_is_paused(is_paused, args, dag=None):
     dag = dag or get_dag(args)
 
-    session = settings.Session()
-    dm = session.query(DagModel).filter(
-        DagModel.dag_id == dag.dag_id).first()
-    dm.is_paused = is_paused
-    session.commit()
 
 Review comment:
   I think the changes will still be committed to the database, otherwise the `expunge_all()` would have the same behavior as the `rollback()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services