You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:55:35 UTC

[GitHub] [cloudstack] rhtyd commented on a change in pull request #4254: Name public network appropriately to avoid conflicts

rhtyd commented on a change in pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467699511



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -198,7 +198,7 @@ public static String getPublicNetworkNamePrefix(String vlanId) {
         if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
             return "cloud.public.untagged";
         } else {
-            return "cloud.public." + vlanId;
+            return "cloud.public." + vlanId + ".";

Review comment:
       @Pearl1594 would that be wrong or cause compatibility issues post upgrade? Generally port group names don't end in period (`.`) cc @PaulAngus @andrijapanicsb @borisstoyanov @vladimirpetrov?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org