You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org> on 2006/07/18 14:23:14 UTC
[jira] Created: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
remove frameset border in afh:frameBorderLayout
-----------------------------------------------
Key: ADFFACES-68
URL: http://issues.apache.org/jira/browse/ADFFACES-68
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Arnaud MERGEY
Priority: Minor
In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
I have hard coded in FrameBorderLayoutRenderer.java
//XXX AM:disable frameset border
writer.writeAttribute("framespacing", "0", null);
writer.writeAttribute("border", "0", null);
writer.writeAttribute("frameborder", "0", null);
It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12422372 ]
Arnaud MERGEY commented on ADFFACES-68:
---------------------------------------
Thanks a lot Pierre-Luc
it works perfectly.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Simon Lessard updated ADFFACES-68:
----------------------------------
Attachment: ADFFACES-68_Java_5.patch
Removed two unused imports.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: ADFFACES-68_Java_5.patch, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, trunk_patch68_v2.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Pierre-Luc Archambault updated ADFFACES-68:
-------------------------------------------
Attachment: trunk_patch68_v2.patch
ADFFACES-68
Modifications for the "faces-major" renderer of Frame and FrameBorderLayout, added call to method rendering shortDesc and StyleClass is some are there. (I wrongly wern't calling them on my first submitted version of the renderer)
Also added a private method to FrameRenderer checking the consisteny of the 'source' string generated as a url; 2 "//" were presents however only 1 was necessary with relative contents. (exemple with popup window from inputDate or inputColor)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, trunk_patch68_v2.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12422140 ]
Arnaud MERGEY commented on ADFFACES-68:
---------------------------------------
Hi Pierre Luc,
this is simple example:
layout.jsp:
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces" prefix="af"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces/html" prefix="afh"%>
<f:view>
<afh:html>
<afh:head title="test" />
<afh:frameBorderLayout>
<f:facet name="alternateContent">
<af:outputText value="This page uses Framesets, but your browser does not support them."/>
</f:facet>
<f:facet name="left">
<afh:frame name="sommaire" source="left.faces" width="150"/>
</f:facet>
<f:facet name="center">
<afh:frameBorderLayout>
<f:facet name="top">
<afh:frame name="banniere" source="top.faces" height="50" scrolling="no"/>
</f:facet>
<f:facet name="center">
<afh:frame name="principal" source="center.faces"/>
</f:facet>
</afh:frameBorderLayout>
</f:facet>
</afh:frameBorderLayout>
</afh:html>
</f:view>
top.jsp:
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces" prefix="af"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces/html" prefix="afh"%>
<f:view>
<af:document inlineStyle="margin:0;background:black;">
<f:facet name="metaContainer">
<f:verbatim>
<meta http-equiv="expires" content="0" />
<meta http-equiv="pragma" content="no-cache" />
<meta http-equiv="cache-control" content="max-age=0, no-cache, no-store, must-revalidate" />
</f:verbatim>
</f:facet>
<af:outputText value="top.jsp" inlineStyle="color:white;"/>
</af:document>
</f:view>
left.jsp:
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces" prefix="af"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces/html" prefix="afh"%>
<f:view>
<af:document inlineStyle="margin:0;background:blue;">
<f:facet name="metaContainer">
<f:verbatim>
<meta http-equiv="expires" content="0" />
<meta http-equiv="pragma" content="no-cache" />
<meta http-equiv="cache-control" content="max-age=0, no-cache, no-store, must-revalidate" />
</f:verbatim>
</f:facet>
<af:outputText value="left.jsp" inlineStyle="color:white;"/>
</af:document>
</f:view>
center.jsp:
<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces" prefix="af"%>
<%@ taglib uri="http://myfaces.apache.org/adf/faces/html" prefix="afh"%>
<f:view>
<af:document inlineStyle="margin:0;background-color:yellow;">
<f:facet name="metaContainer">
<f:verbatim>
<meta http-equiv="expires" content="0" />
<meta http-equiv="pragma" content="no-cache" />
<meta http-equiv="cache-control" content="max-age=0, no-cache, no-store, must-revalidate" />
</f:verbatim>
</f:facet>
<af:outputText value="center.jsp" inlineStyle="color:black;"/>
</af:document>
</f:view>
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Adam Winer updated ADFFACES-68:
-------------------------------
Status: Open (was: Patch Available)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12424499 ]
Arnaud MERGEY commented on ADFFACES-68:
---------------------------------------
All new files are in patch.zip
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12425561 ]
Adam Winer commented on ADFFACES-68:
------------------------------------
Please bring that to adffaces-dev; JIRA is not an effective medium for that purpose.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Adam Winer reassigned ADFFACES-68:
----------------------------------
Assignee: Adam Winer
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, trunk_patch68_v2.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Adam Winer updated ADFFACES-68:
-------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Added feature after some heavy modification to the patch. (The patch as supplied failed the CoreRenderKitTest golden file tests for a bunch of reasons).
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Assigned To: Adam Winer
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, trunk_patch68_v2.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Attachment: patch.zip
I'have updated Pierre-Luc patch to refactored trinidad version
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Status: Patch Available (was: Open)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Pierre-Luc Archambault updated ADFFACES-68:
-------------------------------------------
Attachment: trunk_patch68.patch
This patch contains modification (and addition of 2 files) to have a "faces-major" version of HtmlFrameBorderLayout AND HtmlFrame
Those 2 components seemed intimately close together. Please, if somebody could have a look at what is correctly transitioned and what is not.
The old renderer for both frame and frameborderlayout are in :
org.apache.myfaces.trinidadinternal.ui.laf.base.xhtml
(uses them for comparaison purpose)
awaiting feedback, thanks
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12421934 ]
Pierre-Luc Archambault commented on ADFFACES-68:
------------------------------------------------
Hey Arnaud,
I havn't used an afh:frameBorderLayout yet but I think I could still be able to provide you a small working patch with something better than hardcoded value :)
could you please provide me a small code example of a page using afh:frameBorderLayout and point out the frameset border present (what do they visually looks like) on it that you want to have removed.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: RE [jira] Commented: (ADFFACES-68) remove frameset border in afh:frameBorderLayout
Posted by Adam Winer <aw...@gmail.com>.
The renderers in trinidadinternal.ui.laf are "UIX-major" renderers.
They're based on the wrapping up code in the old UIX framework.
This is complicated code, not inheriting at all from real JSF
Renderers.
The renderers in renderkit.core.xhtml are "Faces-major"; they're
based entirely around JSF concepts. These are much faster
(usually 2x faster).
A major goal of Trinidad is entirely eliminating all of the code
in trinidadinternal.ui and trinidadinternal.uinode.
-- Adam
On 8/2/06, Pierre-Luc_Archambault@dmr.ca <Pi...@dmr.ca> wrote:
> Hiya,
>
> After reading the comments, I agree that integers should be put instead of
> booleans.
> But about the "faces-major" renderer, I am not quite sure I understand
> what is required. Could you elaborate a wee more about the requirements
> and modifications needed to modify it to a "faces-major" renderer ?
>
> thanks,
> Pierre-Luc Archambault
> Fujitsu Consulting
>
> "Adam Winer (JIRA)" <ad...@incubator.apache.org> a écrit sur
> 2006-08-01 17:11:14 :
>
> > [ http://issues.apache.org/jira/browse/ADFFACES-68?
> > page=comments#action_12425018 ]
> >
> > Adam Winer commented on ADFFACES-68:
> > ------------------------------------
> >
> > The attributes should be named borderWidth, frameBorderWidth, and
> > frameSpacing, and be integers, not booleans. Also, instead of
> > patching FrameBorderLayoutRenderer, there should be a new "faces-
> > major" renderer... So, -1 on applying this patch as is.
> >
> > > remove frameset border in afh:frameBorderLayout
> > > -----------------------------------------------
> > >
> > > Key: ADFFACES-68
> > > URL: http://issues.apache.org/jira/browse/ADFFACES-68
> > > Project: MyFaces ADF-Faces
> > > Issue Type: Improvement
> > > Reporter: Arnaud MERGEY
> > > Priority: Minor
> > > Attachments: FrameBorderLayoutRenderer.java,
> > FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch,
> > HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip,
> > withBorder.JPG, withoutBorder.JPG
> > >
> > >
> > > In pages I need to remove frameset border with framespacing and
> > border parameter (ex:<frameset framespacing="0" border="0"
> frameborder="0">).
> > > I have hard coded in FrameBorderLayoutRenderer.java
> > > //XXX AM:disable frameset border
> > > writer.writeAttribute("framespacing", "0", null);
> > > writer.writeAttribute("border", "0", null);
> > > writer.writeAttribute("frameborder", "0", null);
> > > It would be fine to add a parameter in afh:frameBorderLayout to
> > allow conditional removing of frameset border
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >
> >
>
>
RE [jira] Commented: (ADFFACES-68) remove frameset border in afh:frameBorderLayout
Posted by Pi...@dmr.ca.
Hiya,
After reading the comments, I agree that integers should be put instead of
booleans.
But about the "faces-major" renderer, I am not quite sure I understand
what is required. Could you elaborate a wee more about the requirements
and modifications needed to modify it to a "faces-major" renderer ?
thanks,
Pierre-Luc Archambault
Fujitsu Consulting
"Adam Winer (JIRA)" <ad...@incubator.apache.org> a écrit sur
2006-08-01 17:11:14 :
> [ http://issues.apache.org/jira/browse/ADFFACES-68?
> page=comments#action_12425018 ]
>
> Adam Winer commented on ADFFACES-68:
> ------------------------------------
>
> The attributes should be named borderWidth, frameBorderWidth, and
> frameSpacing, and be integers, not booleans. Also, instead of
> patching FrameBorderLayoutRenderer, there should be a new "faces-
> major" renderer... So, -1 on applying this patch as is.
>
> > remove frameset border in afh:frameBorderLayout
> > -----------------------------------------------
> >
> > Key: ADFFACES-68
> > URL: http://issues.apache.org/jira/browse/ADFFACES-68
> > Project: MyFaces ADF-Faces
> > Issue Type: Improvement
> > Reporter: Arnaud MERGEY
> > Priority: Minor
> > Attachments: FrameBorderLayoutRenderer.java,
> FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch,
> HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip,
> withBorder.JPG, withoutBorder.JPG
> >
> >
> > In pages I need to remove frameset border with framespacing and
> border parameter (ex:<frameset framespacing="0" border="0"
frameborder="0">).
> > I have hard coded in FrameBorderLayoutRenderer.java
> > //XXX AM:disable frameset border
> > writer.writeAttribute("framespacing", "0", null);
> > writer.writeAttribute("border", "0", null);
> > writer.writeAttribute("frameborder", "0", null);
> > It would be fine to add a parameter in afh:frameBorderLayout to
> allow conditional removing of frameset border
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
http://www.atlassian.com/software/jira
>
>
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12425018 ]
Adam Winer commented on ADFFACES-68:
------------------------------------
The attributes should be named borderWidth, frameBorderWidth, and frameSpacing, and be integers, not booleans. Also, instead of patching FrameBorderLayoutRenderer, there should be a new "faces-major" renderer... So, -1 on applying this patch as is.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Adam Winer updated ADFFACES-68:
-------------------------------
Status: Open (was: Patch Available)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Attachment: withBorder.JPG
screenshot of result with current trinidad version
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, withBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Pierre-Luc Archambault updated ADFFACES-68:
-------------------------------------------
Attachment: HtmlFrameBorderLayout.patch
FrameBorderLayoutRenderer.patch
I added 3 attributes to the FrameBorderLayout. The 3 attributes are all boolean variables (defaulted at true) and referencing about the border, frameborder and framespacing rendering.
I also modified the FrameBorderLayoutRenderer so that it checks the value of those 3 attributes and set their rendering state accordingly.
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Pierre-Luc Archambault updated ADFFACES-68:
-------------------------------------------
Attachment: HtmlFrameBorderLayout.xml
FrameBorderLayoutRenderer.java
Arnaud, if you wanna try those 2 files with your application here are the 2 path where to put em before you rebuild trinidad.
for the .xml one, put it in :
adf-faces\adf-faces-build\src\main\resources\META-INF\maven-faces-plugin\components\adf\html
for the .java one, put it in :
adf-faces\adf-faces-impl\src\main\java\org\apache\myfaces\adfinternal\ui\laf\base\xhtml
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Attachment: FrameBorderLayoutRenderer.java
modified FrameBorderLayoutRenderer.java removing frameset border
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=comments#action_12425465 ]
Arnaud MERGEY commented on ADFFACES-68:
---------------------------------------
Ok, it is easy to change attributes name and type. Can you provide infos on how to write a new faces major renderer ?
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-68:
---------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: https://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Arnaud MERGEY
> Assigned To: Adam Winer
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
> Attachments: ADFFACES-68_Java_5.patch, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, trunk_patch68_v2.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Pierre-Luc Archambault (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Pierre-Luc Archambault updated ADFFACES-68:
-------------------------------------------
Status: Patch Available (was: Open)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, trunk_patch68.patch, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Status: Patch Available (was: Open)
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.java, FrameBorderLayoutRenderer.patch, HtmlFrameBorderLayout.patch, HtmlFrameBorderLayout.xml, patch.zip, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-68) remove frameset border in
afh:frameBorderLayout
Posted by "Arnaud MERGEY (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-68?page=all ]
Arnaud MERGEY updated ADFFACES-68:
----------------------------------
Attachment: withoutBorder.JPG
screenshot of result with my modified FrameBorderLayoutRenderer.java
> remove frameset border in afh:frameBorderLayout
> -----------------------------------------------
>
> Key: ADFFACES-68
> URL: http://issues.apache.org/jira/browse/ADFFACES-68
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Arnaud MERGEY
> Priority: Minor
> Attachments: FrameBorderLayoutRenderer.java, withBorder.JPG, withoutBorder.JPG
>
>
> In pages I need to remove frameset border with framespacing and border parameter (ex:<frameset framespacing="0" border="0" frameborder="0">).
> I have hard coded in FrameBorderLayoutRenderer.java
> //XXX AM:disable frameset border
> writer.writeAttribute("framespacing", "0", null);
> writer.writeAttribute("border", "0", null);
> writer.writeAttribute("frameborder", "0", null);
> It would be fine to add a parameter in afh:frameBorderLayout to allow conditional removing of frameset border
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira