[GitHub] [ozone] lokeshj1703 commented on a change in pull request #2808: HDDS-5517. Support multiple container moves from a source datanode

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #2808:
URL: https://github.com/apache/ozone/pull/2808#discussion_r744460061



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -93,6 +94,7 @@
   private Map<DatanodeDetails, ContainerMoveSelection> sourceToTargetMap;
   private Map<DatanodeDetails, Long> sizeLeavingNode;
   private Map<DatanodeDetails, Long> sizeEnteringNode;
+  private Map<DatanodeDetails, Long> remainingUsageBeforeOverUtilized;

Review comment:
       I think we should not add this map `remainingUsageBeforeOverUtilized`. We can probably use sizeLeavingNode here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org